Petar.petkovic has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393893 )
Change subject: Fix null reference error on discard translation ...................................................................... Fix null reference error on discard translation - Add additional check before trying to remove class from translation list item action trigger. - Without checking, we get null reference error when user opens actions menu (only when opened on hover) on translation list item and clicks "Discard translation". - Introduced in I52b0e0b8f681de91673e1e6eccea564b72fde0b4. Bug: T181533 Change-Id: I881ace99f9c670525f58504d2a7ee056fbfa540f --- M modules/dashboard/ext.cx.translationlist.js 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation refs/changes/93/393893/1 diff --git a/modules/dashboard/ext.cx.translationlist.js b/modules/dashboard/ext.cx.translationlist.js index 0c7dda9..bb557c5 100644 --- a/modules/dashboard/ext.cx.translationlist.js +++ b/modules/dashboard/ext.cx.translationlist.js @@ -468,7 +468,9 @@ e.stopPropagation(); translation = $( this ).closest( '.cx-tlitem' ).data( 'translation' ); - self.$selectedActionMenu.removeClass( 'cx-tlitem__actions--selected' ); + if ( self.$selectedActionMenu ) { + self.$selectedActionMenu.removeClass( 'cx-tlitem__actions--selected' ); + } OO.ui.getWindowManager().openWindow( 'message', $.extend( { message: mw.msg( 'cx-draft-discard-confirmation-message' ), -- To view, visit https://gerrit.wikimedia.org/r/393893 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I881ace99f9c670525f58504d2a7ee056fbfa540f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ContentTranslation Gerrit-Branch: master Gerrit-Owner: Petar.petkovic <ppetko...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits