VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393919 )

Change subject: themes: Fix PHP ComboboxInputWidget indicator position
......................................................................

themes: Fix PHP ComboboxInputWidget indicator position

Regression from I9d0cbf5d069ae0ecdb56501fb6f352ba68d29c1f

Change-Id: Id98d81542607e6cce20481b9e3069b872519c7b7
---
M src/themes/apex/widgets.less
M src/themes/wikimediaui/widgets.less
2 files changed, 14 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/19/393919/1

diff --git a/src/themes/apex/widgets.less b/src/themes/apex/widgets.less
index 78356a2..d598ec2 100644
--- a/src/themes/apex/widgets.less
+++ b/src/themes/apex/widgets.less
@@ -345,7 +345,13 @@
                }
        }
 
-       &-php .oo-ui-indicatorWidget {
+       // IndicatorWidget is child element,
+       // therefor in need of higher specificity
+       &-php 
.oo-ui-indicatorWidget.oo-ui-indicatorElement.oo-ui-indicatorElement-indicator {
+               display: block;
+               position: absolute;
+               top: 0;
+               height: 100%;
                right: 0;
                max-height: 2.5em;
                margin: 0;
diff --git a/src/themes/wikimediaui/widgets.less 
b/src/themes/wikimediaui/widgets.less
index a597e03..84acb04 100644
--- a/src/themes/wikimediaui/widgets.less
+++ b/src/themes/wikimediaui/widgets.less
@@ -497,7 +497,13 @@
                }
        }
 
-       &-php .oo-ui-indicatorWidget {
+       // IndicatorWidget is child element,
+       // therefor in need of higher specificity
+       &-php 
.oo-ui-indicatorWidget.oo-ui-indicatorElement.oo-ui-indicatorElement-indicator {
+               display: block;
+               position: absolute;
+               top: 0;
+               height: 100%;
                right: @padding-horizontal-base;
                margin: 0;
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/393919
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id98d81542607e6cce20481b9e3069b872519c7b7
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to