Brion VIBBER has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/393941 )

Change subject: Desktop native MP3 at higher priority than ogv.js Ogg
......................................................................

Desktop native MP3 at higher priority than ogv.js Ogg

This gets desktop browsers (Safari, Edge, IE 11) using the
native MP3 audio playback when available in higher priority
than the ogv.js-based Ogg playback.

Browsers with native Ogg playback will continue to see the
Ogg files, which usually is the originals so far.

This brings desktop and mobile more in line with expectations
for what's native/non-native.

Bug: T165717
Change-Id: I52da07bae219e5df5431f9756c4100417d0b5036
---
M MwEmbedModules/EmbedPlayer/EmbedPlayer.config.php
M MwEmbedModules/EmbedPlayer/resources/mw.MediaElement.js
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler 
refs/changes/41/393941/1

diff --git a/MwEmbedModules/EmbedPlayer/EmbedPlayer.config.php 
b/MwEmbedModules/EmbedPlayer/EmbedPlayer.config.php
index 59fa159..7ba89ec 100644
--- a/MwEmbedModules/EmbedPlayer/EmbedPlayer.config.php
+++ b/MwEmbedModules/EmbedPlayer/EmbedPlayer.config.php
@@ -10,7 +10,7 @@
 
                        // The preferred media codec preference
                        // Note user selected format order
-                       'EmbedPlayer.CodecPreference' => array( 'vp9', 'webm', 
'h264', 'ogg', 'mp3' ),
+                       'EmbedPlayer.CodecPreference' => array( 'vp9', 'webm', 
'h264', 'ogg', 'mp3', 'ogvjs' ),
 
                        // If video tag support should be disabled 
all-together, used to test
                        // fallback decoding methods and direct file links
diff --git a/MwEmbedModules/EmbedPlayer/resources/mw.MediaElement.js 
b/MwEmbedModules/EmbedPlayer/resources/mw.MediaElement.js
index f05558a..d378f2e 100644
--- a/MwEmbedModules/EmbedPlayer/resources/mw.MediaElement.js
+++ b/MwEmbedModules/EmbedPlayer/resources/mw.MediaElement.js
@@ -272,7 +272,7 @@
                                                break;
                                        case 'ogvJsPlayer':
                                                useBogoSlow = true;
-                                               var shortName = 'ogg';
+                                               var shortName = 'ogvjs';
                                                break;
                                        case 'webmNative':
                                                var shortName = 'webm';

-- 
To view, visit https://gerrit.wikimedia.org/r/393941
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I52da07bae219e5df5431f9756c4100417d0b5036
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <br...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to