jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/393840 )
Change subject: Update to Mapbox 5.2.0.
......................................................................
Update to Mapbox 5.2.0.
With much crossing of fingers, this might fix crashes we've seen on
Chromebooks... (while not introducing new ones.)
Bug: T164317
Change-Id: I01cf48849c1b269d189349997b3ab4f889fffe23
---
M app/build.gradle
M app/src/main/java/org/wikipedia/nearby/NearbyFragment.java
2 files changed, 4 insertions(+), 5 deletions(-)
Approvals:
jenkins-bot: Verified
Mholloway: Looks good to me, approved
diff --git a/app/build.gradle b/app/build.gradle
index 6bcab7b..2fbdbba 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -201,9 +201,8 @@
implementation "com.squareup.retrofit2:converter-gson:$retrofitVersion"
implementation 'com.getkeepsafe.taptargetview:taptargetview:1.9.1'
implementation "com.jakewharton:butterknife:$butterKnifeVersion"
- implementation('com.mapbox.mapboxsdk:mapbox-android-sdk:5.1.4@aar') {
- transitive = true
- }
+ implementation "com.mapbox.mapboxsdk:mapbox-android-sdk:5.2.0@aar"
+ implementation "com.mapbox.mapboxsdk:mapbox-android-ui:2.2.9"
implementation 'net.hockeyapp.android:HockeySDK:4.1.3'
implementation 'org.apache.commons:commons-lang3:3.5'
implementation "commons-io:commons-io:2.5"
diff --git a/app/src/main/java/org/wikipedia/nearby/NearbyFragment.java
b/app/src/main/java/org/wikipedia/nearby/NearbyFragment.java
index 91f2d64..c5b6425 100644
--- a/app/src/main/java/org/wikipedia/nearby/NearbyFragment.java
+++ b/app/src/main/java/org/wikipedia/nearby/NearbyFragment.java
@@ -28,7 +28,6 @@
import com.mapbox.mapboxsdk.camera.CameraUpdateFactory;
import com.mapbox.mapboxsdk.constants.MyLocationTracking;
import com.mapbox.mapboxsdk.geometry.LatLng;
-import com.mapbox.mapboxsdk.location.LocationSource;
import com.mapbox.mapboxsdk.maps.MapView;
import com.mapbox.mapboxsdk.maps.MapboxMap;
import com.mapbox.mapboxsdk.maps.OnMapReadyCallback;
@@ -36,6 +35,7 @@
import com.mapbox.services.android.telemetry.MapboxTelemetry;
import com.mapbox.services.android.telemetry.location.LocationEngine;
import com.mapbox.services.android.telemetry.location.LocationEngineListener;
+import com.mapbox.services.android.telemetry.location.LocationEngineProvider;
import org.wikipedia.R;
import org.wikipedia.WikipediaApp;
@@ -133,7 +133,7 @@
}
}
- locationEngine = new LocationSource(getContext());
+ locationEngine = new
LocationEngineProvider(getContext()).obtainBestLocationEngineAvailable();
locationEngine.addLocationEngineListener(locationChangeListener);
onLoading();
--
To view, visit https://gerrit.wikimedia.org/r/393840
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I01cf48849c1b269d189349997b3ab4f889fffe23
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Cooltey <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Sharvaniharan <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
