Giuseppe Lavagetto has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/394269 )
Change subject: Gemfile: update rspec-puppet, add rspec-puppet-facts ...................................................................... Gemfile: update rspec-puppet, add rspec-puppet-facts We add rspec-puppet-facts as it's a very useful tool for writing specs without having to care about undeclared base facts. It's particularly useful when we run tests on puppet4, which does error out on undefined variables. Change-Id: I91db13405150d63ec1c36faeee80fa1efecb35f6 --- M Gemfile 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Giuseppe Lavagetto: Looks good to me, approved jenkins-bot: Verified diff --git a/Gemfile b/Gemfile index f5e07ad..2a3342c 100644 --- a/Gemfile +++ b/Gemfile @@ -3,10 +3,9 @@ gem 'puppet', ENV['PUPPET_GEM_VERSION'] || '~> 3.8.5' gem 'xmlrpc' if RUBY_VERSION >= '2.4.0' gem 'puppet-strings', '~> 1.0.0' -gem 'rspec-puppet', '~> 2.5.0' +gem 'rspec-puppet', '~> 2.6.9' +gem 'rspec-puppet-facts', '~> 1.7', :require => false gem 'puppetlabs_spec_helper', '< 2.0.0' -# Puppet 3.7 fails on ruby 2.2+ -# https://tickets.puppetlabs.com/browse/PUP-3796 gem 'safe_yaml', '~> 1.0.4' gem 'rake', '~> 12.0.0' -- To view, visit https://gerrit.wikimedia.org/r/394269 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91db13405150d63ec1c36faeee80fa1efecb35f6 Gerrit-PatchSet: 2 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Giuseppe Lavagetto <glavage...@wikimedia.org> Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
