jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/394526 )

Change subject: objectcache: fix a few documentation mistakes
......................................................................


objectcache: fix a few documentation mistakes

* Fix useInterimHoldOffCaching() description
* Mention when staleTTL and graceTTL where added

Change-Id: Iea24b77f6816251e9dac814dc57f6a44382a3cea
---
M includes/libs/objectcache/WANObjectCache.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Thiemo Mättig (WMDE): Looks good to me, approved



diff --git a/includes/libs/objectcache/WANObjectCache.php 
b/includes/libs/objectcache/WANObjectCache.php
index 74ec7b9..3decef1 100644
--- a/includes/libs/objectcache/WANObjectCache.php
+++ b/includes/libs/objectcache/WANObjectCache.php
@@ -890,6 +890,7 @@
         *      Default: WANObjectCache::STALE_TTL_NONE
         * @return mixed Value found or written to the key
         * @note Options added in 1.28: version, busyValue, hotTTR, ageNew, 
pcGroup, minAsOf
+        * @note Options added in 1.31: staleTTL, graceTTL
         * @note Callable type hints are not used to avoid class-autoloading
         */
        final public function getWithSetCallback( $key, $ttl, $callback, array 
$opts = [] ) {
@@ -1502,7 +1503,7 @@
        }
 
        /**
-        * Disable the use of brief caching for tombstoned keys
+        * Enable or disable the use of brief caching for tombstoned keys
         *
         * When a key is purged via delete(), there normally is a period where 
caching
         * is hold-off limited to an extremely short time. This method will 
disable that

-- 
To view, visit https://gerrit.wikimedia.org/r/394526
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iea24b77f6816251e9dac814dc57f6a44382a3cea
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.kr...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to