Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394665 )
Change subject: objectcache: Fix HashBagOStuffTest test in PHP 7.1 ...................................................................... objectcache: Fix HashBagOStuffTest test in PHP 7.1 > There was 1 error: > > 1) HashBagOStuffTest::testEvictionAdd > A non-numeric value encountered > > tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php:106 This warning is new in PHP 7.1, however the behaviour is not new. This code was already not behaving as it should have. Concatenation preceeds addition/multiplication. As such, this was producing (int)-10 each time instead of (str)"key0" through (str)"key10". Change-Id: Ibb1a59e373740772f02dfec77ee7ebd9d181d852 --- M tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/65/394665/1 diff --git a/tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php b/tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php index b2278c3..53d27c0 100644 --- a/tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php +++ b/tests/phpunit/includes/libs/objectcache/HashBagOStuffTest.php @@ -103,7 +103,7 @@ for ( $i = 10; $i < 20; $i++ ) { $cache->set( "key$i", 1 ); $this->assertEquals( 1, $cache->get( "key$i" ) ); - $this->assertEquals( false, $cache->get( "key" . $i - 10 ) ); + $this->assertEquals( false, $cache->get( "key" . ( $i - 10 ) ) ); } } -- To view, visit https://gerrit.wikimedia.org/r/394665 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibb1a59e373740772f02dfec77ee7ebd9d181d852 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Krinkle <krinklem...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits