Gergő Tisza has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394762 )
Change subject: Fix "Left match operand must result in a String value" in service::node ...................................................................... Fix "Left match operand must result in a String value" in service::node Change-Id: If0a8602065e43fedb6eba13a8a2e0c2e624d203b --- M puppet/modules/service/manifests/node.pp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vagrant refs/changes/62/394762/1 diff --git a/puppet/modules/service/manifests/node.pp b/puppet/modules/service/manifests/node.pp index fe6a042..a88a422 100644 --- a/puppet/modules/service/manifests/node.pp +++ b/puppet/modules/service/manifests/node.pp @@ -76,7 +76,7 @@ } # sanity check since a default port cannot be assigned - unless $port and $port =~ /^\d+$/ { + unless $port and "${port}" =~ /^\d+$/ { fail('Service port must be specified and must be a number!') } -- To view, visit https://gerrit.wikimedia.org/r/394762 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If0a8602065e43fedb6eba13a8a2e0c2e624d203b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/vagrant Gerrit-Branch: stretch-migration Gerrit-Owner: Gergő Tisza <gti...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits