Aaron Schulz has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394773 )

Change subject: Add some @noinspection flags to doPostOutputShutdown()
......................................................................

Add some @noinspection flags to doPostOutputShutdown()

This are in "use" clause of $callback, by reference

Change-Id: Iadb1d25263dbafe2bd12223db62e1c93e2188bde
---
M includes/MediaWiki.php
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/73/394773/1

diff --git a/includes/MediaWiki.php b/includes/MediaWiki.php
index 9e3bc10..2aeefc6 100644
--- a/includes/MediaWiki.php
+++ b/includes/MediaWiki.php
@@ -726,10 +726,12 @@
                if ( function_exists( 'register_postsend_function' ) ) {
                        // https://github.com/facebook/hhvm/issues/1230
                        register_postsend_function( $callback );
+                       /** @noinspection PhpUnusedLocalVariableInspection */
                        $blocksHttpClient = false;
                } else {
                        if ( function_exists( 'fastcgi_finish_request' ) ) {
                                fastcgi_finish_request();
+                               /** @noinspection 
PhpUnusedLocalVariableInspection */
                                $blocksHttpClient = false;
                        } else {
                                // Either all DB and deferred updates should 
happen or none.

-- 
To view, visit https://gerrit.wikimedia.org/r/394773
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iadb1d25263dbafe2bd12223db62e1c93e2188bde
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to