Pppery has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394832 )
Change subject: Parse "show/hide <type of change>" labels on Watchlist and
RecentChanges
......................................................................
Parse "show/hide <type of change>" labels on Watchlist and RecentChanges
Which makes it possible to add links to such titles.
Bug: T142406
Change-Id: I5342b9491df47bbb549e91ebba9d0a8b273a7d17
---
M includes/specials/SpecialRecentchanges.php
M includes/specials/SpecialWatchlist.php
2 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/32/394832/1
diff --git a/includes/specials/SpecialRecentchanges.php
b/includes/specials/SpecialRecentchanges.php
index cfc7a85..bdca301 100644
--- a/includes/specials/SpecialRecentchanges.php
+++ b/includes/specials/SpecialRecentchanges.php
@@ -943,7 +943,7 @@
$links[] = Html::rawElement(
'span',
$attribs,
- $this->msg( $msg )->rawParams( $link
)->escaped()
+ $this->msg( $msg )->rawParams( $link )->parse()
);
}
diff --git a/includes/specials/SpecialWatchlist.php
b/includes/specials/SpecialWatchlist.php
index ff62e9e..7f99e1d 100644
--- a/includes/specials/SpecialWatchlist.php
+++ b/includes/specials/SpecialWatchlist.php
@@ -855,11 +855,11 @@
return Html::rawElement(
'span',
$attribs,
- Xml::checkLabel(
- $this->msg( $message, '' )->text(),
- $name,
- $name,
- (int)$value
+ // not using HTML::checkLabel because that would escape
the contents
+ Html::check( $name, (int)$value, [ 'id' => $name ] ) .
Html::rawElement(
+ 'label',
+ $attribs + [ 'for' => $name ],
+ $this->msg( $message, '' )->parse()
)
);
}
--
To view, visit https://gerrit.wikimedia.org/r/394832
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5342b9491df47bbb549e91ebba9d0a8b273a7d17
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Pppery <maprea...@olum.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
