Zfilipin has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395017 )
Change subject: Update RuboCop Ruby gem ...................................................................... Update RuboCop Ruby gem Had to also update parallel_tests gem. Bug: T180878 Change-Id: I526da0ad840e3226155c5b7fce0ccdbdd7636aae --- M .rubocop_todo.yml M Gemfile M Gemfile.lock 3 files changed, 78 insertions(+), 24 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CirrusSearch refs/changes/17/395017/1 diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index eb43c09..e88082c 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,17 +1,72 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2015-12-18 16:23:11 +0100 using RuboCop version 0.35.1. +# on 2017-12-04 16:34:17 +0100 using RuboCop version 0.51.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 223 -# Configuration parameters: AllowURI, URISchemes. +# Offense count: 1 +# Cop supports --auto-correct. +Layout/EmptyLines: + Exclude: + - 'tests/browser/features/support/hooks.rb' + +# Offense count: 1 +Lint/RescueWithoutErrorClass: + Exclude: + - 'tests/browser/features/support/hooks.rb' + +# Offense count: 258 +# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# URISchemes: http, https Metrics/LineLength: - Max: 252 + Max: 250 # Offense count: 1 # Configuration parameters: CountKeywordArgs. Metrics/ParameterLists: Max: 6 + +# Offense count: 1 +# Cop supports --auto-correct. +Style/Encoding: + Exclude: + - 'tests/browser/features/support/hooks.rb' + +# Offense count: 1 +# Configuration parameters: MinBodyLength. +Style/GuardClause: + Exclude: + - 'tests/browser/features/support/pages/search_results_page.rb' + +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: AutoCorrect, EnforcedStyle, SupportedStyles. +# SupportedStyles: predicate, comparison +Style/NumericPredicate: + Exclude: + - 'spec/**/*' + - 'tests/browser/features/step_definitions/search_steps.rb' + +# Offense count: 4 +# Cop supports --auto-correct. +Style/OrAssignment: + Exclude: + - 'tests/browser/features/step_definitions/page_steps.rb' + - 'tests/browser/features/step_definitions/search_steps.rb' + +# Offense count: 3 +# Cop supports --auto-correct. +# Configuration parameters: PreferredDelimiters. +Style/PercentLiteralDelimiters: + Exclude: + - 'tests/browser/features/step_definitions/search_steps.rb' + +# Offense count: 4 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline. +# SupportedStyles: single_quotes, double_quotes +Style/StringLiterals: + Exclude: + - 'Gemfile' diff --git a/Gemfile b/Gemfile index abd796a..b387f90 100644 --- a/Gemfile +++ b/Gemfile @@ -2,6 +2,6 @@ gem "mediawiki_selenium", "~> 1.8" gem "mimemagic", "~> 0.3.0" -gem "parallel_tests", "~> 1.7.0" +gem 'parallel_tests', '~> 2.19' gem "rake", "~> 10.4", ">= 10.4.2" -gem "rubocop", "~> 0.35.1", require: false +gem 'rubocop', '~> 0.51.0', require: false diff --git a/Gemfile.lock b/Gemfile.lock index 191b71d..82c3463 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1,9 +1,7 @@ GEM remote: https://rubygems.org/ specs: - ast (2.2.0) - astrolabe (1.3.1) - parser (~> 2.2) + ast (2.3.0) builder (3.2.3) childprocess (0.6.2) ffi (~> 1.0, >= 1.0.11) @@ -66,13 +64,14 @@ watir (~> 6.0) page_navigation (0.10) data_magic (>= 0.22) - parallel (1.8.0) - parallel_tests (1.7.1) + parallel (1.12.0) + parallel_tests (2.19.0) parallel - parser (2.3.0.7) - ast (~> 2.2) + parser (2.4.0.2) + ast (~> 2.3) powerpack (0.1.1) - rainbow (2.1.0) + rainbow (2.2.2) + rake rake (10.5.0) rest-client (1.8.0) http-cookie (>= 1.0.2, < 2.0) @@ -81,14 +80,14 @@ rspec-core (2.99.2) rspec-expectations (2.99.2) diff-lcs (>= 1.1.3, < 2.0) - rubocop (0.35.1) - astrolabe (~> 1.3) - parser (>= 2.2.3.0, < 3.0) + rubocop (0.51.0) + parallel (~> 1.10) + parser (>= 2.3.3.1, < 3.0) powerpack (~> 0.1) - rainbow (>= 1.99.1, < 3.0) + rainbow (>= 2.2.2, < 3.0) ruby-progressbar (~> 1.7) - tins (<= 1.6.0) - ruby-progressbar (1.8.0) + unicode-display_width (~> 1.0, >= 1.0.1) + ruby-progressbar (1.9.0) rubyzip (1.2.1) selenium-webdriver (3.1.0) childprocess (~> 0.5) @@ -96,10 +95,10 @@ websocket (~> 1.0) syntax (1.2.1) thor (0.19.4) - tins (1.6.0) unf (0.1.4) unf_ext unf_ext (0.0.7.2) + unicode-display_width (1.3.0) watir (6.2.0) selenium-webdriver (~> 3.0) websocket (1.2.4) @@ -111,9 +110,9 @@ DEPENDENCIES mediawiki_selenium (~> 1.8) mimemagic (~> 0.3.0) - parallel_tests (~> 1.7.0) + parallel_tests (~> 2.19) rake (~> 10.4, >= 10.4.2) - rubocop (~> 0.35.1) + rubocop (~> 0.51.0) BUNDLED WITH - 1.14.5 + 1.16.0 -- To view, visit https://gerrit.wikimedia.org/r/395017 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I526da0ad840e3226155c5b7fce0ccdbdd7636aae Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/CirrusSearch Gerrit-Branch: master Gerrit-Owner: Zfilipin <zfili...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits