Zfilipin has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/395019 )
Change subject: Update RuboCop Ruby gem
......................................................................
Update RuboCop Ruby gem
Bug: T180878
Change-Id: Ie12965e4ca22731f84e9f22a4d96bf90cf63063a
---
M .rubocop.yml
A .rubocop_todo.yml
M Gemfile
M Gemfile.lock
4 files changed, 68 insertions(+), 15 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/19/395019/1
diff --git a/.rubocop.yml b/.rubocop.yml
index 84567a5..3c8a650 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,3 +1,5 @@
+inherit_from: .rubocop_todo.yml
+
AllCops:
StyleGuideCopsOnly: true
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
new file mode 100644
index 0000000..5680096
--- /dev/null
+++ b/.rubocop_todo.yml
@@ -0,0 +1,49 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2017-12-04 16:37:27 +0100 using RuboCop version 0.51.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: empty_lines, no_empty_lines
+Layout/EmptyLinesAroundBlockBody:
+ Exclude:
+ - 'tests/rspec/notification_spec.rb'
+
+# Offense count: 2
+# Configuration parameters: Blacklist.
+# Blacklist: END, (?-mix:EO[A-Z]{1})
+Naming/HeredocDelimiterNaming:
+ Exclude:
+ - 'jsduck_custom_tags.rb'
+
+# Offense count: 2
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: snake_case, camelCase
+Naming/VariableName:
+ Exclude:
+ - 'tests/browser/features/support/echo_api_helper.rb'
+
+# Offense count: 1
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+ Exclude:
+ - 'jsduck_custom_tags.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: AllowMultipleReturnValues.
+Style/RedundantReturn:
+ Exclude:
+ - 'jsduck_custom_tags.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: MinSize, SupportedStyles.
+# SupportedStyles: percent, brackets
+Style/SymbolArray:
+ EnforcedStyle: brackets
diff --git a/Gemfile b/Gemfile
index 70c1a10..a886a2d 100644
--- a/Gemfile
+++ b/Gemfile
@@ -4,4 +4,4 @@
gem 'mediawiki_selenium', '~> 1.8'
gem 'rake', '~> 11.1', '>= 11.1.1'
gem 'rspec-mocks', '~> 2.99', '>= 2.99.4'
-gem 'rubocop', '~> 0.34.2', require: false
+gem 'rubocop', '~> 0.51.0', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
index 7a8d813..64a70a7 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,9 +1,7 @@
GEM
remote: https://rubygems.org/
specs:
- ast (2.1.0)
- astrolabe (1.3.1)
- parser (~> 2.2)
+ ast (2.3.0)
blankslate (3.1.3)
builder (3.2.3)
childprocess (0.6.2)
@@ -70,12 +68,14 @@
watir (~> 6.0)
page_navigation (0.10)
data_magic (>= 0.22)
- parser (2.2.2.6)
- ast (>= 1.1, < 3.0)
+ parallel (1.12.0)
+ parser (2.4.0.2)
+ ast (~> 2.3)
parslet (1.7.1)
blankslate (>= 2.0, <= 4.0)
powerpack (0.1.1)
- rainbow (2.0.0)
+ rainbow (2.2.2)
+ rake
rake (11.1.1)
rest-client (1.8.0)
http-cookie (>= 1.0.2, < 2.0)
@@ -85,13 +85,14 @@
rspec-expectations (2.99.2)
diff-lcs (>= 1.1.3, < 2.0)
rspec-mocks (2.99.4)
- rubocop (0.34.2)
- astrolabe (~> 1.3)
- parser (>= 2.2.2.5, < 3.0)
+ rubocop (0.51.0)
+ parallel (~> 1.10)
+ parser (>= 2.3.3.1, < 3.0)
powerpack (~> 0.1)
- rainbow (>= 1.99.1, < 3.0)
- ruby-progressbar (~> 1.4)
- ruby-progressbar (1.7.5)
+ rainbow (>= 2.2.2, < 3.0)
+ ruby-progressbar (~> 1.7)
+ unicode-display_width (~> 1.0, >= 1.0.1)
+ ruby-progressbar (1.9.0)
rubyzip (1.2.1)
selenium-webdriver (3.1.0)
childprocess (~> 0.5)
@@ -102,6 +103,7 @@
unf (0.1.4)
unf_ext
unf_ext (0.0.7.2)
+ unicode-display_width (1.3.0)
watir (6.2.0)
selenium-webdriver (~> 3.0)
websocket (1.2.4)
@@ -115,7 +117,7 @@
mediawiki_selenium (~> 1.8)
rake (~> 11.1, >= 11.1.1)
rspec-mocks (~> 2.99, >= 2.99.4)
- rubocop (~> 0.34.2)
+ rubocop (~> 0.51.0)
BUNDLED WITH
- 1.14.6
+ 1.16.0
--
To view, visit https://gerrit.wikimedia.org/r/395019
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie12965e4ca22731f84e9f22a4d96bf90cf63063a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
