Bmansurov has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395045 )
Change subject: Remove Extension:Collection related code ...................................................................... Remove Extension:Collection related code The Collection extension has been decommissioned. Bug: T176755 Change-Id: I1922eb7c751f3947f58ce4512a5e0b4d2da6e1e6 --- M src/ElectronPdfServiceHooks.php 1 file changed, 6 insertions(+), 28 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ElectronPdfService refs/changes/45/395045/1 diff --git a/src/ElectronPdfServiceHooks.php b/src/ElectronPdfServiceHooks.php index e470c1d..9b8a65d 100644 --- a/src/ElectronPdfServiceHooks.php +++ b/src/ElectronPdfServiceHooks.php @@ -31,34 +31,12 @@ return true; } - // FIXME: remove logic related to Extension:Collection once we decommission it: T176755. - if ( $config->has( 'CollectionFormats' ) && array_key_exists( 'coll-print_export', $bar ) ) { - $index = self::getIndexOfDownloadPdfSidebarItem( - $bar['coll-print_export'], - $config->get( 'CollectionFormats' ) - ); - // if Collection extension provides a download-as-pdf link, make it point to the download screen - if ( $index !== false ) { - $bar['coll-print_export'][$index]['href'] = self::generateDownloadScreenLink( - $title - ); - // if no download-as-pdf link is there, add one and point to the download screen - } else { - $bar['coll-print_export'][] = [ - 'text' => $skin->msg( 'electronPdfService-sidebar-portlet-print-text' ), - 'id' => 'electron-print_pdf', - 'href' => self::generateDownloadScreenLink( $title ) - ]; - } - } else { - // in case Collection is not installed, let's add our own portlet - // with a link to the download screen - $bar['electronPdfService-sidebar-portlet-heading'][] = [ - 'text' => $skin->msg( 'electronPdfService-sidebar-portlet-print-text' ), - 'id' => 'electron-print_pdf', - 'href' => self::generateDownloadScreenLink( $title ) - ]; - } + // add portlet with a link to the download screen + $bar['electronPdfService-sidebar-portlet-heading'][] = [ + 'text' => $skin->msg( 'electronPdfService-sidebar-portlet-print-text' ), + 'id' => 'electron-print_pdf', + 'href' => self::generateDownloadScreenLink( $title ) + ]; return true; } -- To view, visit https://gerrit.wikimedia.org/r/395045 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1922eb7c751f3947f58ce4512a5e0b4d2da6e1e6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ElectronPdfService Gerrit-Branch: master Gerrit-Owner: Bmansurov <bmansu...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits