Samwilson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395184 )
Change subject: Don't construct HTML manually ...................................................................... Don't construct HTML manually Also some other minor tweaks. Change-Id: Ie99feecfd17134d04e25c796d524028a0cc35c83 --- M README.md M src/Hooks.php M src/Person.php 3 files changed, 9 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Genealogy refs/changes/84/395184/1 diff --git a/README.md b/README.md index 75ac6c3..6e2de20 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,4 @@ MediaWiki Genealogy extension ============================= -All details: https://mediawiki.org/wiki/Extension:Genealogy +All details: https://www.mediawiki.org/wiki/Extension:Genealogy diff --git a/src/Hooks.php b/src/Hooks.php index 267dff2..1e2c3f3 100644 --- a/src/Hooks.php +++ b/src/Hooks.php @@ -3,6 +3,7 @@ namespace MediaWiki\Extensions\Genealogy; use EditPage; +use Html; use MediaWiki\MediaWikiServices; use OutputPage; use Parser; @@ -36,9 +37,9 @@ $peopleList[] = $renderer->makeKnownLink( $partner->getTitle() ); } if ( count( $peopleList ) > 0 ) { - $msg = wfMessage( 'genealogy-existing-partners', count( $peopleList ) ); - $successBox = '<p class="successbox">' . $msg. join( ', ', $peopleList ) . '</p>'; - $output->addHTML( $successBox ); + $msg = $output->msg( 'genealogy-existing-partners', count( $peopleList ) ); + $partnersMsg = $msg . join( ', ', $peopleList ); + $output->addHTML( Html::rawElement( 'p', [], $partnersMsg ) ); } } @@ -47,7 +48,7 @@ * The input parameters are wikitext with templates expanded. * The output should be wikitext too. * @param Parser $parser The parser. - * @return string The wikitext with which to replace the parser function call. + * @return string|mixed[] The wikitext with which to replace the parser function call. */ public static function renderParserFunction( Parser $parser ) { $params = []; @@ -56,7 +57,7 @@ array_shift( $args ); // Get param 1, the function type. $type = array_shift( $args ); - // Everything that's left must be named. + // Everything that remains is required to be named (i.e. we discard other unnamed args). foreach ( $args as $arg ) { $pair = explode( '=', $arg, 2 ); if ( count( $pair ) == 2 ) { diff --git a/src/Person.php b/src/Person.php index a62ff13..825f7e2 100644 --- a/src/Person.php +++ b/src/Person.php @@ -120,7 +120,7 @@ * @return string */ public function getBirthDate() { - return $this->getPropSingle( "birth date" ); + return $this->getPropSingle( 'birth date' ); } /** @@ -128,7 +128,7 @@ * @return string */ public function getDeathDate() { - return $this->getPropSingle( "death date" ); + return $this->getPropSingle( 'death date' ); } /** -- To view, visit https://gerrit.wikimedia.org/r/395184 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie99feecfd17134d04e25c796d524028a0cc35c83 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Genealogy Gerrit-Branch: master Gerrit-Owner: Samwilson <s...@samwilson.id.au> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
