Zfilipin has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/395523 )
Change subject: Update RuboCop Ruby gem
......................................................................
Update RuboCop Ruby gem
Bug: T180878
Change-Id: Ic69b9c079a7ecbdb8cdcae26799bbe6dd8388f49
---
M .rubocop.yml
A .rubocop_todo.yml
M Gemfile
M Gemfile.lock
4 files changed, 83 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/23/395523/1
diff --git a/.rubocop.yml b/.rubocop.yml
index 2befb1d..7360287 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,3 +1,5 @@
+inherit_from: .rubocop_todo.yml
+
AllCops:
Include:
- 'bin/*.rb'
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
new file mode 100644
index 0000000..a452529
--- /dev/null
+++ b/.rubocop_todo.yml
@@ -0,0 +1,67 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2017-12-05 13:52:49 +0100 using RuboCop version 0.51.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+Lint/AmbiguousBlockAssociation:
+ Exclude:
+ - 'bin/testsuitegenerator.rb'
+
+# Offense count: 1
+Lint/EmptyWhen:
+ Exclude:
+ - 'bin/docparser.rb'
+
+# Offense count: 4
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/BlockLength:
+ Max: 188
+
+# Offense count: 2
+# Configuration parameters: ExpectMatchingDefinition, Regex,
IgnoreExecutableScripts, AllowedAcronyms.
+# AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML,
HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP,
TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
+Naming/FileName:
+ Exclude:
+ - 'Gemfile'
+ - 'Rakefile'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: InverseMethods, InverseBlocks.
+Style/InverseMethods:
+ Exclude:
+ - 'bin/dependencytree.rb'
+ - 'bin/doccomparer.rb'
+
+# Offense count: 2
+Style/MultipleComparison:
+ Exclude:
+ - 'bin/docparser.rb'
+
+# Offense count: 11
+# Cop supports --auto-correct.
+Style/StderrPuts:
+ Exclude:
+ - 'bin/doccomparer.rb'
+ - 'bin/docparser.rb'
+ - 'bin/testsuitegenerator.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles,
ConsistentQuotesInMultiline.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiterals:
+ Exclude:
+ - 'Gemfile'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: all_comparison_operators, equality_operators_only
+Style/YodaCondition:
+ Exclude:
+ - 'bin/docparser.rb'
diff --git a/Gemfile b/Gemfile
index d4f581b..7e5d6b5 100644
--- a/Gemfile
+++ b/Gemfile
@@ -1,4 +1,4 @@
source "https://rubygems.org";
-gem "rubocop", require: false
gem "rake", require: false
+gem 'rubocop', '~> 0.51.0', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
index cb7dd80..7613e50 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,27 +1,30 @@
GEM
remote: https://rubygems.org/
specs:
- ast (2.2.0)
- parser (2.3.0.6)
- ast (~> 2.2)
+ ast (2.3.0)
+ parallel (1.12.0)
+ parser (2.4.0.2)
+ ast (~> 2.3)
powerpack (0.1.1)
- rainbow (2.1.0)
+ rainbow (2.2.2)
+ rake
rake (12.3.0)
- rubocop (0.38.0)
- parser (>= 2.3.0.6, < 3.0)
+ rubocop (0.51.0)
+ parallel (~> 1.10)
+ parser (>= 2.3.3.1, < 3.0)
powerpack (~> 0.1)
- rainbow (>= 1.99.1, < 3.0)
+ rainbow (>= 2.2.2, < 3.0)
ruby-progressbar (~> 1.7)
unicode-display_width (~> 1.0, >= 1.0.1)
- ruby-progressbar (1.7.5)
- unicode-display_width (1.0.2)
+ ruby-progressbar (1.9.0)
+ unicode-display_width (1.3.0)
PLATFORMS
ruby
DEPENDENCIES
rake
- rubocop
+ rubocop (~> 0.51.0)
BUNDLED WITH
1.16.0
--
To view, visit https://gerrit.wikimedia.org/r/395523
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic69b9c079a7ecbdb8cdcae26799bbe6dd8388f49
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
