jenkins-bot has submitted this change and it was merged.
Change subject: Add comments for grep
......................................................................
Add comments for grep
* communityvoice-ratings-error-missing-argument is undefined
* communityvoice-ratings-error-no-* are unused
Change-Id: Ib1471b2d28ae39ce010a7d33e200795450d09c09
---
M Modules/Ratings.php
1 file changed, 10 insertions(+), 0 deletions(-)
Approvals:
Siebrand: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Modules/Ratings.php b/Modules/Ratings.php
index e604e9a..478bcb4 100644
--- a/Modules/Ratings.php
+++ b/Modules/Ratings.php
@@ -163,6 +163,10 @@
$args[$argument] = htmlspecialchars(
$args[$argument] );
} else {
$error = true;
+ // Give grep a chance to find the usages:
+ //
communityvoice-ratings-error-missing-argument (undefined)
+ // TODO: The following messages are defined but
unused here:
+ // communityvoice-ratings-error-no-category,
communityvoice-ratings-error-no-title
$errors[] = CommunityVoice::getMessage(
'ratings', 'error-missing-argument',
$argument
);
@@ -188,6 +192,7 @@
'cv_ratings_scale_' . $args['category'] . '_' .
$args['title']
);
// Gets stats message
+ // Give grep a chance to find the usages:
communityvoice-ratings-scale-stats
$stats = CommunityVoice::getMessageParse(
'ratings',
'scale-stats',
@@ -237,6 +242,10 @@
'stats'
=> $stats,
'status' => array(
'ready' => ' ',
+
// Give grep a chance to find the usages:
+
// community-voice-ratings-scale-status-sending,
+
// community-voice-ratings-scale-status-error,
+
// community-voice-ratings-scale-status-thanks
'sending' => CommunityVoice::getMessage(
'ratings', 'scale-status-sending'
),
@@ -360,6 +369,7 @@
// Builds result
$result = array(
'rating' => $rating,
+ // Give grep a chance to find the usages:
communityvoice-ratings-scale-stats
'stats' => CommunityVoice::getMessage(
'ratings',
'scale-stats',
--
To view, visit https://gerrit.wikimedia.org/r/56764
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1471b2d28ae39ce010a7d33e200795450d09c09
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CommunityVoice
Gerrit-Branch: master
Gerrit-Owner: Shirayuki <shirayuk...@gmail.com>
Gerrit-Reviewer: Siebrand <siebr...@wikimedia.org>
Gerrit-Reviewer: Trevor Parscal <tpars...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
