Pppery has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395848 )
Change subject: Re-enable "MediaWiki.Commenting.FunctionComment.MissingReturn" sniff ...................................................................... Re-enable "MediaWiki.Commenting.FunctionComment.MissingReturn" sniff Bug: T175083 Change-Id: Iad521de387dce704db5552168b18f2653cd3e291 --- M .phpcs.xml M includes/ApiQueryPageImages.php 2 files changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PageImages refs/changes/48/395848/1 diff --git a/.phpcs.xml b/.phpcs.xml index 18d84eb..e305f8c 100644 --- a/.phpcs.xml +++ b/.phpcs.xml @@ -2,7 +2,6 @@ <ruleset> <rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki"> <exclude name="MediaWiki.Commenting.FunctionComment.MissingParamComment" /> - <exclude name="MediaWiki.Commenting.FunctionComment.MissingReturn" /> <exclude name="MediaWiki.Files.ClassMatchesFilename.NotMatch" /> <exclude name="MediaWiki.Files.ClassMatchesFilename.WrongCase" /> <exclude name="MediaWiki.Files.OneClassPerFile.MultipleFound" /> diff --git a/includes/ApiQueryPageImages.php b/includes/ApiQueryPageImages.php index 6c3a94b..cff096f 100644 --- a/includes/ApiQueryPageImages.php +++ b/includes/ApiQueryPageImages.php @@ -282,6 +282,7 @@ /** * @see ApiBase::getExamplesMessages() + * @return array */ protected function getExamplesMessages() { return [ -- To view, visit https://gerrit.wikimedia.org/r/395848 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iad521de387dce704db5552168b18f2653cd3e291 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/PageImages Gerrit-Branch: master Gerrit-Owner: Pppery <maprea...@olum.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits