Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/395883 )
Change subject: Check if $responseData['responses'] is set before use
......................................................................
Check if $responseData['responses'] is set before use
When not set assume always an invalid count
Bug: T161283
Change-Id: Id17e04ff73707830be390ef4306845403859861e
---
M includes/MultiSearchRequestLog.php
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CirrusSearch
refs/changes/83/395883/1
diff --git a/includes/MultiSearchRequestLog.php
b/includes/MultiSearchRequestLog.php
index ea1382e..6075979 100644
--- a/includes/MultiSearchRequestLog.php
+++ b/includes/MultiSearchRequestLog.php
@@ -72,7 +72,9 @@
$requestData = array_chunk( $lines, 2 );
$responseData = $this->response->getData();
- if ( count( $requestData ) !== count(
$responseData['responses'] ) ) {
+ if ( !isset( $responseData['responses'] ) ||
+ count( $requestData ) !== count(
$responseData['responses'] )
+ ) {
// The world has ended...:(
// @todo add more context.
throw new \RuntimeException( 'Request and response data
does not match' );
--
To view, visit https://gerrit.wikimedia.org/r/395883
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id17e04ff73707830be390ef4306845403859861e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
