jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/395677 )
Change subject: Remove unreachable page name clear ...................................................................... Remove unreachable page name clear * pageName is always set. If this were a useful feature, it could be implemented w/ titleMissing, but it's not, the page is always parsed in the context of a name. Change-Id: I0df7d6204f01c0f73070ae370b9d66a879ef08bb --- M lib/api/routes.js 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Subramanya Sastry: Looks good to me, approved jenkins-bot: Verified diff --git a/lib/api/routes.js b/lib/api/routes.js index 7ca157f..f7969db 100644 --- a/lib/api/routes.js +++ b/lib/api/routes.js @@ -344,11 +344,6 @@ startTimers.set('wt2html.wt.parse', Date.now()); metrics.timing('wt2html.wt.size.input', wikitext.length); } - - if (!res.locals.pageName) { - // clear default page name - env.page.name = ''; - } } else if (oldid) { envOptions.pageWithOldid = true; -- To view, visit https://gerrit.wikimedia.org/r/395677 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0df7d6204f01c0f73070ae370b9d66a879ef08bb Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/services/parsoid Gerrit-Branch: master Gerrit-Owner: Arlolra <abrea...@wikimedia.org> Gerrit-Reviewer: Arlolra <abrea...@wikimedia.org> Gerrit-Reviewer: C. Scott Ananian <canan...@wikimedia.org> Gerrit-Reviewer: Sbailey <sbai...@wikimedia.org> Gerrit-Reviewer: Subramanya Sastry <ssas...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits