jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/395493 )
Change subject: Update RuboCop Ruby gem ...................................................................... Update RuboCop Ruby gem Bug: T180878 Change-Id: If3d846ba41c5c5e23519c464adfcc2ba14a747e1 --- M .rubocop_todo.yml M Gemfile M Gemfile.lock 3 files changed, 74 insertions(+), 33 deletions(-) Approvals: jenkins-bot: Verified Jdlrobson: Looks good to me, approved diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 60eeff0..20184ed 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,39 +1,75 @@ -# This configuration was generated by `rubocop --auto-gen-config` -# on 2014-12-05 09:03:35 -0700 using RuboCop version 0.27.1. +# This configuration was generated by +# `rubocop --auto-gen-config` +# on 2017-12-06 12:11:09 +0000 using RuboCop version 0.51.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 9 +# Offense count: 1 Lint/AmbiguousRegexpLiteral: - Enabled: false + Exclude: + - 'tests/browser/features/step_definitions/common_steps.rb' # Offense count: 1 -Lint/ParenthesesAsGroupedExpression: - Enabled: false +Lint/InterpolationCheck: + Exclude: + - 'tests/browser/features/step_definitions/special_watchlist_steps.rb' # Offense count: 1 # Configuration parameters: CountComments. Metrics/ClassLength: - Max: 200 + Max: 130 -# Offense count: 54 -# Configuration parameters: AllowURI, URISchemes. +# Offense count: 32 +# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# URISchemes: http, https Metrics/LineLength: - Max: 428 + Max: 156 -# Offense count: 13 +# Offense count: 3 +# Cop supports --auto-correct. +Performance/StringReplacement: + Exclude: + - 'tests/browser/features/step_definitions/common_steps.rb' + - 'tests/browser/features/step_definitions/create_page_api_steps.rb' + +# Offense count: 14 Style/Documentation: - Enabled: false + Exclude: + - 'spec/**/*' + - 'test/**/*' + - 'tests/browser/features/support/pages/article_page.rb' + - 'tests/browser/features/support/pages/create_article_page.rb' + - 'tests/browser/features/support/pages/diff_page.rb' + - 'tests/browser/features/support/pages/language_page.rb' + - 'tests/browser/features/support/pages/main_page.rb' + - 'tests/browser/features/support/pages/notification_page.rb' + - 'tests/browser/features/support/pages/page.rb' + - 'tests/browser/features/support/pages/special_history_page.rb' + - 'tests/browser/features/support/pages/special_mobilediff_page.rb' + - 'tests/browser/features/support/pages/special_search_page.rb' + - 'tests/browser/features/support/pages/special_userlogin_page.rb' + - 'tests/browser/features/support/pages/user_page.rb' + - 'tests/browser/features/support/pages/watchlist_page.rb' # Offense count: 1 -# Configuration parameters: AllowedVariables. -Style/GlobalVars: - Enabled: false +Style/MixinUsage: + Exclude: + - 'tests/browser/features/support/pages/special_history_page.rb' + +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes. +# SupportedStyles: slashes, percent_r, mixed +Style/RegexpLiteral: + Exclude: + - 'tests/browser/features/support/pages/user_page.rb' # Offense count: 1 # Cop supports --auto-correct. -Style/RedundantSelf: - Enabled: false - +# Configuration parameters: IgnoredMethods. +# IgnoredMethods: respond_to, define_method +Style/SymbolProc: + Exclude: + - 'tests/browser/features/support/hooks.rb' diff --git a/Gemfile b/Gemfile index 144b926..18753bc 100644 --- a/Gemfile +++ b/Gemfile @@ -4,4 +4,4 @@ gem 'mediawiki_selenium', '~> 1.7', '>= 1.7.3' gem 'page-object', '1.1.0' gem 'rake', '~> 10.4', '>= 10.4.2' -gem 'rubocop', '~> 0.29.1', require: false +gem 'rubocop', '~> 0.51.0', require: false diff --git a/Gemfile.lock b/Gemfile.lock index 0b46fb7..4f96163 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1,9 +1,7 @@ GEM remote: https://rubygems.org/ specs: - ast (2.2.0) - astrolabe (1.3.1) - parser (~> 2.2) + ast (2.3.0) builder (3.2.2) childprocess (0.5.9) ffi (~> 1.0, >= 1.0.11) @@ -64,10 +62,12 @@ watir-webdriver (>= 0.6.11) page_navigation (0.9) data_magic (>= 0.14) - parser (2.3.0.7) - ast (~> 2.2) + parallel (1.12.0) + parser (2.4.0.2) + ast (~> 2.3) powerpack (0.1.1) - rainbow (2.1.0) + rainbow (2.2.2) + rake rake (10.5.0) rest-client (1.8.0) http-cookie (>= 1.0.2, < 2.0) @@ -76,14 +76,15 @@ rspec-core (2.99.2) rspec-expectations (2.99.2) diff-lcs (>= 1.1.3, < 2.0) - rubocop (0.29.1) - astrolabe (~> 1.3) - parser (>= 2.2.0.1, < 3.0) + rubocop (0.51.0) + parallel (~> 1.10) + parser (>= 2.3.3.1, < 3.0) powerpack (~> 0.1) - rainbow (>= 1.99.1, < 3.0) - ruby-progressbar (~> 1.4) - ruby-progressbar (1.8.0) - rubyzip (1.2.0) + rainbow (>= 2.2.2, < 3.0) + ruby-progressbar (~> 1.7) + unicode-display_width (~> 1.0, >= 1.0.1) + ruby-progressbar (1.9.0) + rubyzip (1.2.1) selenium-webdriver (2.53.0) childprocess (~> 0.5) rubyzip (~> 1.0) @@ -93,6 +94,7 @@ unf (0.1.4) unf_ext unf_ext (0.0.7.2) + unicode-display_width (1.3.0) watir-webdriver (0.9.1) selenium-webdriver (>= 2.46.2) websocket (1.2.3) @@ -106,4 +108,7 @@ mediawiki_selenium (~> 1.7, >= 1.7.3) page-object (= 1.1.0) rake (~> 10.4, >= 10.4.2) - rubocop (~> 0.29.1) + rubocop (~> 0.51.0) + +BUNDLED WITH + 1.16.0 -- To view, visit https://gerrit.wikimedia.org/r/395493 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If3d846ba41c5c5e23519c464adfcc2ba14a747e1 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Zfilipin <zfili...@wikimedia.org> Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: Phuedx <samsm...@wikimedia.org> Gerrit-Reviewer: Pmiazga <pmia...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits