Matmarex has uploaded a new change for review.
https://gerrit.wikimedia.org/r/57180
Change subject: jquery.makeCollapsible: use 'mw-collapsible' event namespace
......................................................................
jquery.makeCollapsible: use 'mw-collapsible' event namespace
For consistency with the module name.
Change-Id: Ied13e5abdec107771e80418feb4bb3b2f0d54567
---
M RELEASE-NOTES-1.22
M resources/jquery/jquery.makeCollapsible.js
2 files changed, 7 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/80/57180/1
diff --git a/RELEASE-NOTES-1.22 b/RELEASE-NOTES-1.22
index 9b562ae..4366d0d 100644
--- a/RELEASE-NOTES-1.22
+++ b/RELEASE-NOTES-1.22
@@ -27,6 +27,8 @@
* redirect.php was removed. It was unused.
* BREAKING CHANGE: Legacy skins Simple, MySkin and Standard were all removed.
Nostalgia was moved to an extension.
+* Event namespace used by jquery.makeCollapsible has been changed from
+ 'mw-collapse' to 'mw-collapsible' for consistency with the module name.
== Compatibility ==
diff --git a/resources/jquery/jquery.makeCollapsible.js
b/resources/jquery/jquery.makeCollapsible.js
index 630002d..3600c5d 100644
--- a/resources/jquery/jquery.makeCollapsible.js
+++ b/resources/jquery/jquery.makeCollapsible.js
@@ -274,7 +274,7 @@
.parent()
.prepend( ' [' )
.append( '] ' )
- .on( 'click.mw-collapse',
function ( e, opts ) {
+ .on( 'click.mw-collapsible',
function ( e, opts ) {
opts = $.extend( {
toggleText: { collapseText: collapsetext, expandText: expandtext } }, options,
opts );
toggleLinkDefault(
$(this), e, opts );
} );
@@ -298,7 +298,7 @@
// Bind the custom togglers
if ( $customTogglers && $customTogglers.length ) {
- $customTogglers.on( 'click.mw-collapse',
function ( e, opts ) {
+ $customTogglers.on( 'click.mw-collapsible',
function ( e, opts ) {
opts = $.extend( {}, options, opts );
toggleLinkCustom( $(this), e, opts,
$collapsible );
} );
@@ -324,7 +324,7 @@
if ( !$toggle.length ) {
$firstItem.eq(-1).prepend(
$toggleLink );
} else {
- $toggleLink = $toggle.off(
'click.mw-collapse' ).on( 'click.mw-collapse', function ( e, opts ) {
+ $toggleLink = $toggle.off(
'click.mw-collapsible' ).on( 'click.mw-collapsible', function ( e, opts ) {
opts = $.extend( {},
options, opts );
toggleLinkPremade(
$toggle, e, opts );
} );
@@ -346,7 +346,7 @@
}
$collapsible.prepend(
$toggleLink.wrap( '<li class="mw-collapsible-toggle-li"></li>' ).parent() );
} else {
- $toggleLink = $toggle.off(
'click.mw-collapse' ).on( 'click.mw-collapse', function ( e, opts ) {
+ $toggleLink = $toggle.off(
'click.mw-collapsible' ).on( 'click.mw-collapsible', function ( e, opts ) {
opts = $.extend( {},
options, opts );
toggleLinkPremade(
$toggle, e, opts );
} );
@@ -366,7 +366,7 @@
if ( !$toggle.length ) {
$collapsible.prepend(
$toggleLink );
} else {
- $toggleLink = $toggle.off(
'click.mw-collapse' ).on( 'click.mw-collapse', function ( e, opts ) {
+ $toggleLink = $toggle.off(
'click.mw-collapsible' ).on( 'click.mw-collapsible', function ( e, opts ) {
opts = $.extend( {},
options, opts );
toggleLinkPremade(
$toggle, e, opts );
} );
--
To view, visit https://gerrit.wikimedia.org/r/57180
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied13e5abdec107771e80418feb4bb3b2f0d54567
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Matmarex <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
