jenkins-bot has submitted this change and it was merged.
Change subject: ResourceLoader: Change $module by ref instead of resetting the
key
......................................................................
ResourceLoader: Change $module by ref instead of resetting the key
Change-Id: I8590352b52ecf51def21a9c52af85aba0f050ff8
---
M includes/resourceloader/ResourceLoader.php
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/resourceloader/ResourceLoader.php
b/includes/resourceloader/ResourceLoader.php
index 589a354..9abd1fa 100644
--- a/includes/resourceloader/ResourceLoader.php
+++ b/includes/resourceloader/ResourceLoader.php
@@ -286,12 +286,12 @@
// Add the testrunner (which configures QUnit) to the
dependencies.
// Since it must be ready before any of the test suites are
executed.
- foreach( $testModules['qunit'] as $moduleName => $moduleProps )
{
+ foreach( $testModules['qunit'] as &$module ) {
// Make sure all test modules are top-loading so that
when QUnit starts
// on document-ready, it will run once and finish. If
some tests arrive
// later (possibly after QUnit has already finished)
they will be ignored.
- $testModules['qunit'][$moduleName]['position'] = 'top';
- $testModules['qunit'][$moduleName]['dependencies'][] =
'mediawiki.tests.qunit.testrunner';
+ $module['position'] = 'top';
+ $module['dependencies'][] =
'mediawiki.tests.qunit.testrunner';
}
foreach( $testModules as $id => $names ) {
--
To view, visit https://gerrit.wikimedia.org/r/57181
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8590352b52ecf51def21a9c52af85aba0f050ff8
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
