jenkins-bot has submitted this change and it was merged.
Change subject: Moving basic titlelink param handling to the parent formatter
class...
......................................................................
Moving basic titlelink param handling to the parent formatter class...
...since the logic for handling it is there already.
Change-Id: I7dab19caf07f770befb2969eefd0f2ab3337bd94
---
M formatters/BasicFormatter.php
M formatters/EditFormatter.php
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Mattflaschen: Looks good to me, but someone else must approve
Bsitu: Looks good to me, approved
jenkins-bot: Verified
diff --git a/formatters/BasicFormatter.php b/formatters/BasicFormatter.php
index 25de60b..0717f61 100644
--- a/formatters/BasicFormatter.php
+++ b/formatters/BasicFormatter.php
@@ -342,6 +342,8 @@
} else {
$message->params( $this->formatTitle(
$event->getTitle() ) );
}
+ } elseif ( $param === 'titlelink' ) {
+ $this->setTitleLink( $event, $message );
} elseif ( $param === 'text-notification' ) {
$oldOutputFormat = $this->outputFormat;
$this->setOutputFormat( 'text' );
diff --git a/formatters/EditFormatter.php b/formatters/EditFormatter.php
index b585f03..3b9cc06 100644
--- a/formatters/EditFormatter.php
+++ b/formatters/EditFormatter.php
@@ -24,8 +24,6 @@
)
);
$this->setTitleLink( $event, $message, $props );
- } elseif ( $param === 'titlelink' ) {
- $this->setTitleLink( $event, $message );
} elseif ( $param === 'summary' ) {
$eventData = $event->getExtra();
if ( !isset( $eventData['revid'] ) ) {
--
To view, visit https://gerrit.wikimedia.org/r/56332
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7dab19caf07f770befb2969eefd0f2ab3337bd94
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Kaldari <[email protected]>
Gerrit-Reviewer: Bsitu <[email protected]>
Gerrit-Reviewer: Lwelling <[email protected]>
Gerrit-Reviewer: Mattflaschen <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
