Divadsn has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397595 )
Change subject: Internationalize hardcoded strings from New Task ...................................................................... Internationalize hardcoded strings from New Task Bug: T96418 Change-Id: I40c42f76f8f4060be1d974a3586301bec94b9b63 --- M i18n/en.json M i18n/qqq.json M src/MassActionSpecialPage.php 3 files changed, 18 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MassAction refs/changes/95/397595/1 diff --git a/i18n/en.json b/i18n/en.json index 1d7a682..38cb06c 100644 --- a/i18n/en.json +++ b/i18n/en.json @@ -1,7 +1,8 @@ { "@metadata": { "authors": [ - "Addshore" + "Addshore", + "Divadsn" ] }, "massaction": "Mass action interface", @@ -11,6 +12,7 @@ "massaction-newtask": "New task", "massaction-viewtask": "View task", "massaction-registeredtask": "Task registered and job queued!", + "massaction-title": "Mass Action", "massactionsavechange": "Save change", "specialpages-group-MassAction": "MassAction", "log-name-massaction": "MassAction", @@ -45,5 +47,8 @@ "massaction-view-task-target-identifier": "Identifier", "massaction-view-task-target-name": "Name", "massaction-view-task-target-state": "State", - "massaction-view-task-target-save": "Save" + "massaction-view-task-target-save": "Save", + "massaction-new-task-title": "New $1 task", + "massaction-new-task-select-title": "New Task - Select Target", + "massaction-new-task-submit-title": "New Task - Submit" } diff --git a/i18n/qqq.json b/i18n/qqq.json index 04810a4..58d622a 100644 --- a/i18n/qqq.json +++ b/i18n/qqq.json @@ -3,7 +3,8 @@ "authors": [ "Liuxinyu970226", "Robby", - "Umherirrender" + "Umherirrender", + "Divadsn" ] }, "massaction": "Main special page title", @@ -13,6 +14,7 @@ "massaction-newtask": "New Task special page title", "massaction-viewtask": "View Task special page title", "massaction-registeredtask": "Message for when a task has been registered and the corresponding job has been added to the queue for later completion", + "massaction-title": "Title for default page", "massactionsavechange": "Save Change special page title\n{{Identical|Save changes}}", "specialpages-group-MassAction": "MassAction special page group\n{{doc-special-group}}", "log-name-massaction": "Name for the MassAction log type", @@ -47,5 +49,8 @@ "massaction-view-task-target-identifier": "Text that shows in table heading for target identifier", "massaction-view-task-target-name": "Text that shows in table heading for target name\n{{Identical|Name}}", "massaction-view-task-target-state": "Text that shows in table heading for target state", - "massaction-view-task-target-save": "Text that shows in submit button for saving target changes\n{{Identical|Save}}" + "massaction-view-task-target-save": "Text that shows in submit button for saving target changes\n{{Identical|Save}}", + "massaction-new-task-title": "Title for page to create a new task. Parameters:\n* $1 - task target", + "massaction-new-task-select-title": "Title for page to select task target", + "massaction-new-task-submit-title": "Title for page to submit new task" } diff --git a/src/MassActionSpecialPage.php b/src/MassActionSpecialPage.php index 51e650d..f33b2a2 100644 --- a/src/MassActionSpecialPage.php +++ b/src/MassActionSpecialPage.php @@ -75,7 +75,7 @@ } private function executeDefault() { - $this->getOutput()->setPageTitle( 'Mass Action' ); + $this->getOutput()->setPageTitle( wfMessage( 'massaction-title' ) ); $html = ''; $html .= Linker::specialLink( 'MassAction/New', 'massaction-newtask' ); $html .= Html::element( 'br' ); @@ -306,7 +306,7 @@ } private function executeSelectTargetForm() { - $this->getOutput()->setPageTitle( 'New Task - Select Target' ); + $this->getOutput()->setPageTitle( wfMessage( 'massaction-new-task-select-title' ) ); $html = ''; $html .= Html::openElement( 'ul' ); @@ -331,7 +331,7 @@ * @throws Exception */ private function executeTaskOptionsForm( $target ) { - $this->getOutput()->setPageTitle( 'New ' . $target . ' Task' ); + $this->getOutput()->setPageTitle( wfMessage( 'massaction-new-task-title', $target ) ); $this->getOutput()->addModules( 'ext.MassAction.SpecialMassAction.New' ); $formDescription = array_merge( @@ -427,7 +427,7 @@ } private function handlePostNewTask() { - $this->getOutput()->setPageTitle( 'New Task - Submit' ); + $this->getOutput()->setPageTitle( wfMessage( 'massaction-new-task-submit-title' ) ); if ( !$this->getUser()->matchEditToken( $this->getRequest()->getVal( 'wpEditToken' ) ) ) { throw new Exception( 'Did not match csrf token' ); -- To view, visit https://gerrit.wikimedia.org/r/397595 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I40c42f76f8f4060be1d974a3586301bec94b9b63 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MassAction Gerrit-Branch: master Gerrit-Owner: Divadsn <divad.nnamtd...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits