Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397730 )

Change subject: aptrepo: move Hiera calls into parameters
......................................................................

aptrepo: move Hiera calls into parameters

Change-Id: I154a6d41fbbcd4323ab7d9fa60ef195b0470c822
---
M modules/aptrepo/manifests/rsync.pp
1 file changed, 4 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/30/397730/1

diff --git a/modules/aptrepo/manifests/rsync.pp 
b/modules/aptrepo/manifests/rsync.pp
index 1e796fd..877fb40 100644
--- a/modules/aptrepo/manifests/rsync.pp
+++ b/modules/aptrepo/manifests/rsync.pp
@@ -1,10 +1,9 @@
 # sets up rsync of APT repos between 2 servers
 # activates rsync for push from the primary to secondary
-class aptrepo::rsync {
-
-    $primary_server = hiera('install_server', 'install1002.wikimedia.org')
-    $secondary_server = hiera('install_server_failover', 
'install2002.wikimedia.org')
-
+class aptrepo::rsync (
+    $primary_server = hiera('install_server'),
+    $secondary_server = hiera('install_server_failover'),
+){
     # only activate rsync/firewall hole on the server that is NOT active
     if $::fqdn == $primary_server {
 

-- 
To view, visit https://gerrit.wikimedia.org/r/397730
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I154a6d41fbbcd4323ab7d9fa60ef195b0470c822
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <dz...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to