Tobias Gritschacher has submitted this change and it was merged.
Change subject: (minor) removed commented out stuff from selenium test
......................................................................
(minor) removed commented out stuff from selenium test
Change-Id: I3447e77147b67801273795116357bee6c45ca69e
---
M repo/tests/selenium/statements/statements_deleted_prop_spec.rb
1 file changed, 2 insertions(+), 15 deletions(-)
Approvals:
Tobias Gritschacher: Verified; Looks good to me, approved
diff --git a/repo/tests/selenium/statements/statements_deleted_prop_spec.rb
b/repo/tests/selenium/statements/statements_deleted_prop_spec.rb
index 41b9eac..38184d2 100644
--- a/repo/tests/selenium/statements/statements_deleted_prop_spec.rb
+++ b/repo/tests/selenium/statements/statements_deleted_prop_spec.rb
@@ -71,8 +71,6 @@
page.navigate_to items[0]["url"]
page.wait_for_entity_to_load
page.add_statement(properties_cm[0]["label"], cm_string)
- # TODO: refresh needed because of bug 44101 & bug 44547
- #@browser.refresh
page.add_reference_to_first_claim(properties_cm[0]["label"], cm_string)
page.statement1Name.should == properties_cm[0]["label"]
page.statement1ClaimValue1.should == cm_string
@@ -152,23 +150,12 @@
page.statement1Name.should_not == properties_item[0]["label"]
page.statement1Name.include?(properties_item[0]["id"]).should be_true
page.statement1Name.include?("Deleted property").should be_true
- # TODO: there's still a bug in the UI showing the referenced item as
"deleted": bug 45904
- #page.editFirstStatement
- #page.statementValueInput.should == cm_string
- #page.statementValueInput_element.clear
- #page.statementValueInput = items[0]["label"]
- #page.saveStatement
- #ajax_wait
- #page.wbErrorDiv?.should be_true
- #page.cancelStatement
+
page.toggle_reference_section
page.reference1Property.should_not == properties_item[0]["label"]
page.reference1Property.include?(properties_item[0]["id"]).should
be_true
page.reference1Property.include?("Deleted property").should be_true
- # TODO: there's still a bug in the UI showing the referenced item as
"deleted": bug 45904
- #page.reference1ValueLink?.should be_false
- #page.editReference1
- #page.referenceValueInput.should == cm_string
+
# TODO: should it be allowed to edit a reference whose property was
deleted?
#page.referenceValueInput_element.clear
#page.referenceValueInput = "changed"
--
To view, visit https://gerrit.wikimedia.org/r/57293
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3447e77147b67801273795116357bee6c45ca69e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
