Phuedx has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398116 )
Change subject: Update MobileContext#logMobileMode documentation
......................................................................
Update MobileContext#logMobileMode documentation
... with a note to update the documentation for the X-Analytics header,
which it affects.
Change-Id: I4d5677e9c6631196219946bcf9ac37945fa5445e
---
M includes/MobileContext.php
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/16/398116/1
diff --git a/includes/MobileContext.php b/includes/MobileContext.php
index c5e1946..a8c0c21 100644
--- a/includes/MobileContext.php
+++ b/includes/MobileContext.php
@@ -1108,6 +1108,9 @@
* Adds analytics log items if the user is in beta mode
*
* Invoked from MobileFrontendHooks::onRequestContextCreateSkin()
+ *
+ * Making changes to what this method logs? Make sure you update the
+ * documentation for the X-Analytics header:
https://wikitech.wikimedia.org/wiki/X-Analytics
*/
public function logMobileMode() {
if ( $this->isBetaGroupMember() ) {
--
To view, visit https://gerrit.wikimedia.org/r/398116
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d5677e9c6631196219946bcf9ac37945fa5445e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Phuedx <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
