Volans has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/398236 )

Change subject: puppet common: make check more resilient
......................................................................


puppet common: make check more resilient

* Ensure that the file exists

Change-Id: I0e802d288821439f4c75db139f0755580a93fc76
---
M modules/base/files/puppet/puppet-common.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Volans: Looks good to me, approved



diff --git a/modules/base/files/puppet/puppet-common.sh 
b/modules/base/files/puppet/puppet-common.sh
index 7996bbd..5af86c1 100755
--- a/modules/base/files/puppet/puppet-common.sh
+++ b/modules/base/files/puppet/puppet-common.sh
@@ -65,7 +65,7 @@
 RUBY_SCRIPT
     )
 
-    if [[ "$(ruby -e "${ruby_script}" < "${PUPPET_SUMMARY}")" -eq "0" ]]; then
+    if [[ -e "${PUPPET_SUMMARY}" && "$(ruby -e "${ruby_script}" < 
"${PUPPET_SUMMARY}")" -eq "0" ]]; then
         return 0
     fi
 

-- 
To view, visit https://gerrit.wikimedia.org/r/398236
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0e802d288821439f4c75db139f0755580a93fc76
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Volans <rcocci...@wikimedia.org>
Gerrit-Reviewer: Elukey <ltosc...@wikimedia.org>
Gerrit-Reviewer: Gehel <guillaume.leder...@wikimedia.org>
Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org>
Gerrit-Reviewer: Marostegui <maroste...@wikimedia.org>
Gerrit-Reviewer: Volans <rcocci...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to