Petar.petkovic has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398239 )
Change subject: Fix getNamespace error ...................................................................... Fix getNamespace error In mw.rcfilters.init file, getNamespace method is introduced in Id55702ecbe. That method is invoked through 'this' context, which can be different depending on how init method is invoked, which can lead to errors, causing RCFilters not to render correctly. Change-Id: Ifd9cb49e547077c622a5a3757361a85d99283f62 (cherry picked from commit 8a3e9c0e08a13d83352299b314b5d19a72594a37) --- M resources/src/mediawiki.rcfilters/mw.rcfilters.init.js 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/39/398239/1 diff --git a/resources/src/mediawiki.rcfilters/mw.rcfilters.init.js b/resources/src/mediawiki.rcfilters/mw.rcfilters.init.js index 565ac0a..100fa0b 100644 --- a/resources/src/mediawiki.rcfilters/mw.rcfilters.init.js +++ b/resources/src/mediawiki.rcfilters/mw.rcfilters.init.js @@ -95,7 +95,7 @@ controller.initialize( mw.config.get( 'wgStructuredChangeFilters' ), // All namespaces without Media namespace - this.getNamespaces( [ 'Media' ] ), + rcfilters.getNamespaces( [ 'Media' ] ), mw.config.get( 'wgRCFiltersChangeTags' ), conditionalViews ); -- To view, visit https://gerrit.wikimedia.org/r/398239 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifd9cb49e547077c622a5a3757361a85d99283f62 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.31.0-wmf.12 Gerrit-Owner: Petar.petkovic <ppetko...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits