BearND has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/398268 )

Change subject: Fix onthisday entries from day pages
......................................................................

Fix onthisday entries from day pages

Since HTML5 section ids were deployed,
onthisday entries from day pages (=everything except 'selected')
were missing.
Instead of using the anchorencoded ids we need to use the,
much more readable, Unicode characters.

Bug: T182868
Change-Id: I98b8456d12c5b3b827411229b82abfb644c78630
---
M lib/feed/on-this-day.languages.js
1 file changed, 21 insertions(+), 25 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/68/398268/1

diff --git a/lib/feed/on-this-day.languages.js 
b/lib/feed/on-this-day.languages.js
index 2edf72f..f008d1f 100644
--- a/lib/feed/on-this-day.languages.js
+++ b/lib/feed/on-this-day.languages.js
@@ -46,8 +46,8 @@
                 events: ['Ereignisse'],
                 holidays: [
                     'Feier-_und_Gedenktage',
-                    'Feier-.2C_Gedenk-_und_Aktionstage',
-                    'Feier-.2C_Aktions-_und_Gedenktage'
+                    'Feier-,_Gedenk-_und_Aktionstage',
+                    'Feier-,_Aktions-_und_Gedenktage'
                 ]
             }
         },
@@ -78,9 +78,9 @@
             },
             headingIds: {
                 births: ['Naissances'],
-                deaths: ['D.C3.A9c.C3.A8s'],          // Décès
-                events: ['.C3.89v.C3.A9nements', '.C3.89v.C3.A8nements'], // 
Événements + Évènements
-                holidays: ['C.C3.A9l.C3.A9brations']  // Célébrations
+                deaths: ['Décès'],
+                events: ['Événements', 'Évènements'],
+                holidays: ['Célébrations']
             }
         },
         selectedPage: {
@@ -111,10 +111,10 @@
             // https://sv.wikipedia.org/api/rest_v1/page/html/22_maj
             nameFormatter : (monthName, monthNumber, dayNumber) => 
`${dayNumber}_${monthName}`,
             headingIds: {
-                births: ['F.C3.B6dda'],       // Födda
+                births: ['Födda'],
                 deaths: ['Avlidna'],
-                events: ['H.C3.A4ndelser'],   // Händelser
-                holidays: ['.C3.85terkommande_bem.C3.A4rkelsedagar'] // 
Återkommande bemärkelsedagar
+                events: ['Händelser'],
+                holidays: ['Återkommande bemärkelsedagar']
             }
         },
         selectedPage : {
@@ -139,8 +139,8 @@
             headingIds: {
                 births: ['Nascimentos'],
                 deaths: ['Mortes', 'Falecimentos'],
-                events: ['Eventos', 'Eventos_hist.C3.B3ricos'],
-                holidays: ['Feriados_e_eventos_c.C3.ADclicos']
+                events: ['Eventos', 'Eventos_históricos'],
+                holidays: ['Feriados_e_eventos_cíclicos']
             }
         },
         selectedPage : {
@@ -164,17 +164,14 @@
             // https://ru.wikipedia.org/api/rest_v1/page/html/22_мая
             nameFormatter : (monthName, monthNumber, dayNumber) => 
`${dayNumber}_${monthName}`,
             headingIds: {
-                births: ['.D0.A0.D0.BE.D0.B4.D0.B8.D0.BB.D0.B8.D1.81.D1.8C'],
-                deaths: 
['.D0.A1.D0.BA.D0.BE.D0.BD.D1.87.D0.B0.D0.BB.D0.B8.D1.81.D1.8C'],
-                events: ['.D0.A1.D0.BE.D0.B1.D1.8B.D1.82.D0.B8.D1.8F'],
+                births: ['Родились'],
+                deaths: ['Скончались'],
+                events: ['События'],
                 holidays: [
-                    '.D0.9F.D1.80.D0.B0.D0.B7.D0.B4.D0.BD.D0.B8.D0.BA.D0.B8',
-                    // eslint-disable-next-line max-len
-                    
'.D0.9F.D1.80.D0.B0.D0.B7.D0.B4.D0.BD.D0.B8.D0.BA.D0.B8_.D0.B8_.D0.BF.D0.B0.D0.BC.D1.8F.D1.82.D0.BD.D1.8B.D0.B5_.D0.B4.D0.BD.D0.B8',
-                    // eslint-disable-next-line max-len
-                    
'.D0.9F.D1.80.D0.B0.D0.B7.D0.B4.D0.BD.D0.B8.D0.BA.D0.B8_.D0.B8_.D0.BF.D0.B0.D0.BC.D1.8F.D1.82.D0.BD.D1.8B.D0.B5_.D0.B4.D0.B0.D1.82.D1.8B',
-                    // eslint-disable-next-line max-len
-                    
'.D0.9F.D1.80.D0.B0.D0.B7.D0.B4.D0.BD.D0.B8.D0.BA.D0.B8.2C_.D0.BF.D0.B0.D0.BC.D1.8F.D1.82.D0.BD.D1.8B.D0.B5_.D0.B4.D0.B0.D1.82.D1.8B'
+                    'Праздники',
+                    'Праздники_и_памятные_дни',
+                    'Праздники_и_памятные_даты',
+                    'Праздники,_памятные_даты'
                 ]
             }
         },
@@ -227,11 +224,10 @@
             // https://ar.wikipedia.org/api/rest_v1/page/html/22_مايو
             nameFormatter : (monthName, monthNumber, dayNumber) => 
`${dayNumber}_${monthName}`,
             headingIds: {
-                births: ['.D9.85.D9.88.D8.A7.D9.84.D9.8A.D8.AF'],
-                deaths: ['.D9.88.D9.81.D9.8A.D8.A7.D8.AA'],
-                events: ['.D8.A3.D8.AD.D8.AF.D8.A7.D8.AB'],
-                // eslint-disable-next-line max-len
-                holidays: 
['.D8.A3.D8.B9.D9.8A.D8.A7.D8.AF_.D9.88.D9.85.D9.86.D8.A7.D8.B3.D8.A8.D8.A7.D8.AA']
+                births: ['مواليد'],
+                deaths: ['وفيات'],
+                events: ['أحداث'],
+                holidays: ['أعياد_ومناسبات']
             }
         },
         selectedPage : {

-- 
To view, visit https://gerrit.wikimedia.org/r/398268
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I98b8456d12c5b3b827411229b82abfb644c78630
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND <bsitzm...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to