Thiemo Kreuz (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398796 )
Change subject: Replace class_exists with proper extension registration checks
......................................................................
Replace class_exists with proper extension registration checks
Bug: T183096
Change-Id: I42e2c084bcf472f45be5aa3ef6046cccf0cdaf5f
---
M AdvancedSearch.hooks.php
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AdvancedSearch
refs/changes/96/398796/1
diff --git a/AdvancedSearch.hooks.php b/AdvancedSearch.hooks.php
index 48899ea..61803fb 100644
--- a/AdvancedSearch.hooks.php
+++ b/AdvancedSearch.hooks.php
@@ -3,6 +3,7 @@
namespace AdvancedSearch;
use BetaFeatures;
+use ExtensionRegistry;
use MediaWiki\MediaWikiServices;
use ResourceLoader;
use SpecialPage;
@@ -22,12 +23,12 @@
* If the BetaFeatures extension is loaded then require the
current user
* to have the feature enabled.
*/
- if (
- class_exists( BetaFeatures::class ) &&
- !BetaFeatures::isFeatureEnabled( $special->getUser(),
'advancedsearch' )
+ if ( ExtensionRegistry::getInstance()->isLoaded( 'BetaFeatures'
)
+ && !BetaFeatures::isFeatureEnabled(
$special->getUser(), 'advancedsearch' )
) {
return;
}
+
if ( $special->getName() === 'Search' ) {
$special->getOutput()->addModules(
'ext.advancedSearch.init' );
$special->getOutput()->addModuleStyles(
'ext.advancedSearch.initialstyles' );
--
To view, visit https://gerrit.wikimedia.org/r/398796
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I42e2c084bcf472f45be5aa3ef6046cccf0cdaf5f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AdvancedSearch
Gerrit-Branch: master
Gerrit-Owner: Thiemo Kreuz (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
