Sebastian Berlin (WMSE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398851 )
Change subject: Refactor Javascript modules ...................................................................... Refactor Javascript modules Split up the, at this point quite big, ext.wikispeech. Some methods were also moved from ext.wikispeech.selectionPlayer. The new modules are both smaller and have a more specific tasks. The modules are now (all starting with ext.wikispeech): * main - initializes the rest of the modules, when approriate. * storage - holds utterances and does calculation for utterances and DOM. * player - playback control. * selectionPlayer - logic for reciting selected text. * ui - adds GUI and handles user input. * highlighter - higlights text when reciting. * util - functions that are used by multiple modules without having a strong connection to any of them. A couple of failing tests are now fixed, possibly as a result over earlier patches. Bug: T182205 Bug: T174799 Change-Id: Ic199134bf171ba778048f2461cce1d9a61ff5433 --- M Hooks.php M extension.json M modules/ext.wikispeech.highlighter.js D modules/ext.wikispeech.js A modules/ext.wikispeech.main.js A modules/ext.wikispeech.player.js M modules/ext.wikispeech.selectionPlayer.js A modules/ext.wikispeech.storage.js A modules/ext.wikispeech.ui.js M modules/ext.wikispeech.util.js M tests/qunit/ext.wikispeech.highlighter.test.js A tests/qunit/ext.wikispeech.main.test.js A tests/qunit/ext.wikispeech.player.test.js M tests/qunit/ext.wikispeech.selectionPlayer.test.js A tests/qunit/ext.wikispeech.storage.test.js D tests/qunit/ext.wikispeech.test.js A tests/qunit/ext.wikispeech.ui.test.js 17 files changed, 4,508 insertions(+), 4,076 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikispeech refs/changes/51/398851/1 -- To view, visit https://gerrit.wikimedia.org/r/398851 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic199134bf171ba778048f2461cce1d9a61ff5433 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikispeech Gerrit-Branch: master Gerrit-Owner: Sebastian Berlin (WMSE) <sebastian.ber...@wikimedia.se> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
