jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/398866 )
Change subject: Sort preselected namespaces by number ...................................................................... Sort preselected namespaces by number Bug: T181727 Change-Id: I99caf904deda72f1462961248469c7b85d8a2594 --- M modules/dm/ext.advancedSearch.SearchModel.js 1 file changed, 23 insertions(+), 1 deletion(-) Approvals: jenkins-bot: Verified Andrew-WMDE: Looks good to me, approved diff --git a/modules/dm/ext.advancedSearch.SearchModel.js b/modules/dm/ext.advancedSearch.SearchModel.js index 92cbd27..63bb090 100644 --- a/modules/dm/ext.advancedSearch.SearchModel.js +++ b/modules/dm/ext.advancedSearch.SearchModel.js @@ -207,6 +207,28 @@ /** * @param {Array} namespaces + * @return {Array} + */ + mw.libs.advancedSearch.dm.SearchModel.prototype.sortNamespacesByNumber = function ( namespaces ) { + var sortedNamespaces; + + sortedNamespaces = namespaces.sort( function ( a, b ) { + a = parseInt( a, 10 ); + b = parseInt( b, 10 ); + if ( a < b ) { + return -1; + } + if ( a > b ) { + return 1; + } + return 0; + } ); + + return sortedNamespaces; + }; + + /** + * @param {Array} namespaces */ mw.libs.advancedSearch.dm.SearchModel.prototype.setNamespaces = function ( namespaces ) { var previousNamespaces = this.namespaces.slice( 0 ); @@ -215,7 +237,7 @@ } if ( namespaces.length ) { - this.namespaces = namespaces; + this.namespaces = this.sortNamespacesByNumber( namespaces ); } else { this.namespaces = [ mw.libs.advancedSearch.dm.SearchModel.MAIN_NAMESPACE ]; } -- To view, visit https://gerrit.wikimedia.org/r/398866 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99caf904deda72f1462961248469c7b85d8a2594 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/AdvancedSearch Gerrit-Branch: master Gerrit-Owner: WMDE-Fisch <christoph.jau...@wikimedia.de> Gerrit-Reviewer: Addshore <addshorew...@gmail.com> Gerrit-Reviewer: Andrew-WMDE <andrew.kos...@wikimedia.de> Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits