jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/399656 )
Change subject: Remove ESLint inline comments in WebdriverIO configuration files ...................................................................... Remove ESLint inline comments in WebdriverIO configuration files Comments are not needed. ESLint has configuration file(s). Bug: T175179 Change-Id: Ieafd7b5666faaccb73b8ef7daa7aef3ed4114662 --- M tests/selenium/wdio.conf.jenkins.js M tests/selenium/wdio.conf.js 2 files changed, 2 insertions(+), 7 deletions(-) Approvals: jenkins-bot: Verified Thiemo Kreuz (WMDE): Looks good to me, approved DCausse: Looks good to me, but someone else must approve diff --git a/tests/selenium/wdio.conf.jenkins.js b/tests/selenium/wdio.conf.jenkins.js index 59e1878..26881eb 100644 --- a/tests/selenium/wdio.conf.jenkins.js +++ b/tests/selenium/wdio.conf.jenkins.js @@ -1,5 +1,3 @@ -/* eslint no-undef: "error" */ -/* eslint-env node */ 'use strict'; const merge = require( 'deepmerge' ), password = 'testpass', diff --git a/tests/selenium/wdio.conf.js b/tests/selenium/wdio.conf.js index cf9da0c..5eba0e0 100644 --- a/tests/selenium/wdio.conf.js +++ b/tests/selenium/wdio.conf.js @@ -1,6 +1,3 @@ -/* eslint-env node */ -/* eslint no-undef: "error" */ -/* eslint-disable no-console, comma-dangle */ 'use strict'; const password = 'vagrant', @@ -51,7 +48,7 @@ relPath( './tests/selenium/specs/**/*.js' ), relPath( './extensions/*/tests/selenium/specs/**/*.js' ), relPath( './extensions/VisualEditor/modules/ve-mw/tests/selenium/specs/**/*.js' ), - relPath( './skins/*/tests/selenium/specs/**/*.js' ), + relPath( './skins/*/tests/selenium/specs/**/*.js' ) ], // Patterns to exclude. exclude: [ @@ -233,7 +230,7 @@ // save screenshot browser.saveScreenshot( filePath ); console.log( '\n\tScreenshot location:', filePath, '\n' ); - }, + } // // Hook that gets executed after the suite has ended // afterSuite: function (suite) { -- To view, visit https://gerrit.wikimedia.org/r/399656 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieafd7b5666faaccb73b8ef7daa7aef3ed4114662 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Zfilipin <zfili...@wikimedia.org> Gerrit-Reviewer: DCausse <dcau...@wikimedia.org> Gerrit-Reviewer: EBernhardson <ebernhard...@wikimedia.org> Gerrit-Reviewer: Esanders <esand...@wikimedia.org> Gerrit-Reviewer: Hashar <has...@free.fr> Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: Phuedx <samsm...@wikimedia.org> Gerrit-Reviewer: Thiemo Kreuz (WMDE) <thiemo.kr...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits