Ebe123 has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399893 )
Change subject: Add variables to score hash ...................................................................... Add variables to score hash This change adds the versions of both the extension and of Lilypond to the hash options, so that updates, such as Ieb1345582, that will affect the appearance of a score, will propagate better. Bug: T49448 Change-Id: Iad119d53e4f25ac66e3aa1d553580f0097b6c395 --- M includes/Score.php 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Score refs/changes/93/399893/1 diff --git a/includes/Score.php b/includes/Score.php index e3b76c8..7eea37e 100644 --- a/includes/Score.php +++ b/includes/Score.php @@ -270,10 +270,13 @@ } // Input for cache key + $LYversion = json_decode( file_get_contents( __DIR__ . 'extension.json' ), true )['version']; $cacheOptions = [ 'code' => $code, 'lang' => $options['lang'], 'raw' => $options['raw'], + 'ExtVersion' => $LYversion, + 'LyVersion' => self::getLilypondVersion(), ]; // Doing this separately to not invalidate too many existing keys. if ( $options['raw'] && ( $options['generate_ogg'] -- To view, visit https://gerrit.wikimedia.org/r/399893 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iad119d53e4f25ac66e3aa1d553580f0097b6c395 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Score Gerrit-Branch: master Gerrit-Owner: Ebe123 <beauleetien...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits