jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/399762 )
Change subject: Changed &$this in hooks
......................................................................
Changed &$this in hooks
&$this triggers warnings in PHP 7.1.
Renaming the variable before passing it by reference avoids the warning,
without breaking backwards compatibility.
Bug: T153505
Change-Id: I6d8d61b044eb7b0d0bbb8bd2547665bb85954047
---
M WebPlatformTemplate.class.php
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/WebPlatformTemplate.class.php b/WebPlatformTemplate.class.php
index 12005ba..7476e7e 100644
--- a/WebPlatformTemplate.class.php
+++ b/WebPlatformTemplate.class.php
@@ -109,7 +109,8 @@
<ol id="breadcrumb-info"
class="breadcrumbs">
<li><a
href="http://webplatform.org/";>HOME</a></li>
<li><a href="<?php echo
htmlspecialchars( $this->data['nav_urls']['mainpage']['href'] )
?>">DOCS</a></li>
- <?php Hooks::run(
'SkinBreadcrumb', [ &$this ] ); ?>
+ <?php $skinTemplate =
$this; ?>
+ <?php Hooks::run(
'SkinBreadcrumb', [ &$skinTemplate ] ); ?>
</ol>
</div>
@@ -121,7 +122,8 @@
</div>
<div id="page">
<div id="page-content">
- <?php /* wfRunHooks( 'SkinTOC',
[ &$this ] );*/ ?>
+ <?php /* $skinTemplate =
$this;*/ ?>
+ <?php /* wfRunHooks( 'SkinTOC',
[ &$skinTemplate ] );*/ ?>
<div id="main-content">
<?php if (
$this->data['sitenotice'] ): ?>
--
To view, visit https://gerrit.wikimedia.org/r/399762
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d8d61b044eb7b0d0bbb8bd2547665bb85954047
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/skins/webplatform
Gerrit-Branch: master
Gerrit-Owner: Ryan10145 <chang.ryan10...@gmail.com>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Thiemo Kreuz (WMDE) <thiemo.kr...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
