01tonythomas has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/399995 )
Change subject: Add a unit test to check newsletter creation validation
......................................................................
Add a unit test to check newsletter creation validation
Bug: T183632
Change-Id: I91f1414facf08b0ef3fc50984096532c3371bbf3
---
M tests/specials/SpecialNewsletterCreateTest.php
1 file changed, 18 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Newsletter
refs/changes/95/399995/1
diff --git a/tests/specials/SpecialNewsletterCreateTest.php
b/tests/specials/SpecialNewsletterCreateTest.php
index a928437..adbc2a3 100644
--- a/tests/specials/SpecialNewsletterCreateTest.php
+++ b/tests/specials/SpecialNewsletterCreateTest.php
@@ -19,4 +19,22 @@
$this->executeSpecialPage( '', null, null, $user->getUser() );
$this->assertTrue( true );
}
+
+ public function testCreateNewsletterValidationTest() {
+ $input = [
+ 'name' => 'Test Newsletter',
+ 'description' => 'Test description',
+ 'mainpage' => Title::newFromText('TestPage'
)->getBaseText()
+ ];
+
+ // Mock the submission of this text
+ $res = $this->newSpecialPage()->onSubmit( $input );
+
+ // The description is too small
+ $this->assertEquals(
+ $res->getMessage()->getKey(),
'newsletter-create-short-description-error'
+ );
+
+ //@TODO mock bad main page, mock existing main page, etc
+ }
}
--
To view, visit https://gerrit.wikimedia.org/r/399995
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I91f1414facf08b0ef3fc50984096532c3371bbf3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: 01tonythomas <01tonytho...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
