jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/400169 )
Change subject: Fix the return type of Scribunto_LuaLibraryBase::register()
......................................................................
Fix the return type of Scribunto_LuaLibraryBase::register()
Before this, tools like Phan and others read
`Scribunto_LuaLibraryBase::register()` returns `\Lua` type
from the document comment,
but it actually returns `array` type since the implementation
of this function should returns the value of
`Scribunto_LuaEngine::registerInterface()` which returns
`array` type.
Change-Id: I25beea963444b715bed7b2890475c0c812949520
---
M engines/LuaCommon/LibraryBase.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/engines/LuaCommon/LibraryBase.php
b/engines/LuaCommon/LibraryBase.php
index b929281..fdd3d66 100644
--- a/engines/LuaCommon/LibraryBase.php
+++ b/engines/LuaCommon/LibraryBase.php
@@ -46,7 +46,7 @@
* The value returned by that call should be returned from this
function,
* and must be for 'deferLoad' libraries to work right.
*
- * @return Lua package
+ * @return array Lua package
*/
abstract function register();
--
To view, visit https://gerrit.wikimedia.org/r/400169
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I25beea963444b715bed7b2890475c0c812949520
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Scribunto
Gerrit-Branch: master
Gerrit-Owner: Rafidaslam <rafidt...@gmail.com>
Gerrit-Reviewer: Anomie <bjor...@wikimedia.org>
Gerrit-Reviewer: Jackmcbarn <jackmcb...@gmail.com>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
