Rafidaslam has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/400205 )
Change subject: download_dump: Use response.iter_content
......................................................................
download_dump: Use response.iter_content
Use `response.iter_content` instead of `response.raw`
and add `stream=True` when fetching the dump file.\
Bug: T183666
Change-Id: I92ae2cef5b6f43b0be689e498f1c0b530d197b4a
---
M scripts/maintenance/download_dump.py
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core
refs/changes/05/400205/1
diff --git a/scripts/maintenance/download_dump.py
b/scripts/maintenance/download_dump.py
index 9793255..d8c8d00 100644
--- a/scripts/maintenance/download_dump.py
+++ b/scripts/maintenance/download_dump.py
@@ -18,11 +18,10 @@
#
from __future__ import absolute_import, division, unicode_literals
-import io
import os.path
import sys
-from shutil import copyfile, copyfileobj
+from shutil import copyfile
import pywikibot
@@ -78,11 +77,12 @@
os.path.join(self.getOption('wikiname'),
'latest', download_filename)
pywikibot.output('Downloading file from ' + url)
- response = fetch(url)
+ response = fetch(url, stream=True)
if response.status == 200:
try:
with open(file_storepath, 'wb') as result_file:
- copyfileobj(io.BytesIO(response.raw), result_file)
+ for chunk in response.data.iter_content(100 * 1024):
+ result_file.write(chunk)
except IOError:
pywikibot.exception()
return False
--
To view, visit https://gerrit.wikimedia.org/r/400205
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I92ae2cef5b6f43b0be689e498f1c0b530d197b4a
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Rafidaslam <rafidt...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
