Phuedx has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/400408 )
Change subject: Revision: Handle all return values of Title::newFromId ...................................................................... Revision: Handle all return values of Title::newFromId In Revision::getKnownCurrent, fail early when Title::newFromId returns null to avoid an uncatchable fatal error being triggered. RevisionStore#getKnownCurrentRevision requires that the title parameter be an instance of Title. This follows on from Ia4c20a91. Change-Id: I9bddafcc5df630d1dff1e2526194186cab7097e5 --- M includes/Revision.php 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/08/400408/1 diff --git a/includes/Revision.php b/includes/Revision.php index 8f36e88..b8b56a3 100644 --- a/includes/Revision.php +++ b/includes/Revision.php @@ -1204,6 +1204,10 @@ ? $pageIdOrTitle : Title::newFromID( $pageIdOrTitle ); + if ( !$title ) { + return false; + } + $record = self::getRevisionStore()->getKnownCurrentRevision( $title, $revId ); return $record ? new Revision( $record ) : false; } -- To view, visit https://gerrit.wikimedia.org/r/400408 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9bddafcc5df630d1dff1e2526194186cab7097e5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Phuedx <samsm...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits