Thiemo Kreuz (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/400566 )
Change subject: Update inline documentation
......................................................................
Update inline documentation
Change-Id: I1b44ed37c096af04e27387721952842d999fedaa
---
M src/CognateHooks.php
M src/CognateStore.php
M src/CognateUpdater.php
M src/hooks/CognatePageHookHandler.php
4 files changed, 11 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Cognate
refs/changes/66/400566/1
diff --git a/src/CognateHooks.php b/src/CognateHooks.php
index 865a08f..b0dd233 100644
--- a/src/CognateHooks.php
+++ b/src/CognateHooks.php
@@ -81,7 +81,7 @@
*
* @see CognateUpdater regarding the complexities of this hook
*
- * @param DatabaseUpdater $updater DatabaseUpdater object
+ * @param DatabaseUpdater $updater
* @return bool
*/
public static function onLoadExtensionSchemaUpdates( DatabaseUpdater
$updater ) {
diff --git a/src/CognateStore.php b/src/CognateStore.php
index 469da7b..926d274 100644
--- a/src/CognateStore.php
+++ b/src/CognateStore.php
@@ -323,7 +323,10 @@
/**
* Delete all entries from the cognate_pages table for the given site.
+ *
* @param string $dbName The dbname of the site to delete pages for.
+ *
+ * @throws RuntimeException if not run in a maintenance or test scope
*/
public function deletePagesForSite( $dbName ) {
if ( !defined( 'RUN_MAINTENANCE_IF_MAIN' ) && !defined(
'MW_PHPUNIT_TEST' ) ) {
diff --git a/src/CognateUpdater.php b/src/CognateUpdater.php
index 8f63fd4..797b51a 100644
--- a/src/CognateUpdater.php
+++ b/src/CognateUpdater.php
@@ -63,7 +63,7 @@
/**
* @suppress PhanTypeMissingReturn
- * @return array
+ * @return null
*/
protected function getCoreUpdateList() {
// not used but is abstract and must be implemented
diff --git a/src/hooks/CognatePageHookHandler.php
b/src/hooks/CognatePageHookHandler.php
index 342cbb8..96065c7 100644
--- a/src/hooks/CognatePageHookHandler.php
+++ b/src/hooks/CognatePageHookHandler.php
@@ -68,14 +68,14 @@
* Occurs after the save page request has been processed.
* @see
https://www.mediawiki.org/wiki/Manual:Hooks/PageContentSaveComplete
*
- * @param WikiPage $page
- * @param User $user
+ * @param WikiPage &$page
+ * @param User &$user
* @param Content $content
* @param string $summary
- * @param boolean $isMinor
- * @param boolean $isWatch
- * @param mixed $section Deprecated
- * @param integer $flags
+ * @param bool $isMinor
+ * @param null $isWatch No longer used
+ * @param null $section No longer used
+ * @param int &$flags
* @param Revision|null $revision
* @param Status $status
* @param integer $baseRevId
--
To view, visit https://gerrit.wikimedia.org/r/400566
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b44ed37c096af04e27387721952842d999fedaa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cognate
Gerrit-Branch: master
Gerrit-Owner: Thiemo Kreuz (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
