jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/400717 )
Change subject: Avoid PHP 7.1 warning of &$this usage
......................................................................
Avoid PHP 7.1 warning of &$this usage
Bug: T153505
Change-Id: I7b55990cfe583bfc705f7a9d1ab89c3ddd6128c5
---
M WPtouch.skin.php
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Florianschmidtwelzow: Looks good to me, approved
jenkins-bot: Verified
diff --git a/WPtouch.skin.php b/WPtouch.skin.php
index 465948e..4060f91 100644
--- a/WPtouch.skin.php
+++ b/WPtouch.skin.php
@@ -156,8 +156,9 @@
foreach ( $this->getToolbox() as $key => $item
) {
echo $this->makeListItem( $key, $item );
}
-
- Hooks::run( 'SkinTemplateToolboxEnd', array(
&$this, true ) );
+ // Avoid PHP 7.1 warning of passing $this by
reference
+ $skin = $this;
+ Hooks::run( 'SkinTemplateToolboxEnd', array(
&$skin, true ) );
?>
</ul>
--
To view, visit https://gerrit.wikimedia.org/r/400717
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b55990cfe583bfc705f7a9d1ab89c3ddd6128c5
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/skins/WPtouch
Gerrit-Branch: master
Gerrit-Owner: LukBukkit <luk.buk...@gmail.com>
Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
