jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/401045 )
Change subject: Warn on usage of each()
......................................................................
Warn on usage of each()
foreach should be used instead.
Bug: T174354
Change-Id: I3543a1e40732ced397a929bb0e4a16a4f66cb240
---
M MediaWiki/Sniffs/Usage/ForbiddenFunctionsSniff.php
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Florianschmidtwelzow: Looks good to me, approved
jenkins-bot: Verified
diff --git a/MediaWiki/Sniffs/Usage/ForbiddenFunctionsSniff.php
b/MediaWiki/Sniffs/Usage/ForbiddenFunctionsSniff.php
index e3e4045..d607ea8 100644
--- a/MediaWiki/Sniffs/Usage/ForbiddenFunctionsSniff.php
+++ b/MediaWiki/Sniffs/Usage/ForbiddenFunctionsSniff.php
@@ -32,8 +32,10 @@
*/
private $functions = [
'is_integer' => 'is_int',
- 'create_function' => false,
'extract' => false,
+ // Deprecated in PHP 7.2
+ 'create_function' => false,
+ 'each' => false,
];
/**
--
To view, visit https://gerrit.wikimedia.org/r/401045
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3543a1e40732ced397a929bb0e4a16a4f66cb240
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
