Xqt has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/401378 )
Change subject: [compat2core] compat library parts are accessible directly
......................................................................
[compat2core] compat library parts are accessible directly
pywikibot/compat is part of the sys.path modified by teh pwb.py wrapper script.
It is not necessary to import catlib, userlib or query from pywikibot.compat
but it could be imported directly.
Change-Id: I96a5422b9d2efe4a6c55e7ad9aa4029068659818
---
M README-conversion.txt
M scripts/maintenance/compat2core.py
2 files changed, 2 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core
refs/changes/78/401378/1
diff --git a/README-conversion.txt b/README-conversion.txt
index d89dec1..1d1c0bd 100644
--- a/README-conversion.txt
+++ b/README-conversion.txt
@@ -29,9 +29,6 @@
change "import wikipedia" to "import pywikibot"
change "import pagegenerators" to "from pywikibot import pagegenerators"
change "import config" to "from pywikibot import config"
- change "import catlib" to "from pywikibot.compat import catlib"
- change "import query" to "from pywikibot.compat import query"
- change "import userlib" to "from pywikibot.compat import userlib"
change "wikipedia." to "pywikibot."
wikipedia.setAction() no longer works; you must revise the script to pass an
diff --git a/scripts/maintenance/compat2core.py
b/scripts/maintenance/compat2core.py
index 4e62b64..f5c8610 100755
--- a/scripts/maintenance/compat2core.py
+++ b/scripts/maintenance/compat2core.py
@@ -26,8 +26,8 @@
python pwb.py compat2core <scriptname> -warnonly
"""
#
-# (C) xqt, 2014-2017
-# (C) Pywikibot team, 2014-2017
+# (C) xqt, 2014-2018
+# (C) Pywikibot team, 2014-2018
#
# Distributed under the terms of the MIT license.
#
@@ -50,8 +50,6 @@
('import wikipedia(?: as pywikibot)?', 'import pywikibot'),
('(?<!from pywikibot )import (config|pagegenerators)',
r'from pywikibot import \1'),
- ('(?<!from pywikibot.compat )import query',
- 'from pywikibot.compat import query'),
# remove deprecated libs
('import catlib\r?\n', ''),
('import userlib\r?\n', ''),
--
To view, visit https://gerrit.wikimedia.org/r/401378
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I96a5422b9d2efe4a6c55e7ad9aa4029068659818
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Xqt <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
