jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/401721 )
Change subject: Type hint against IDatabase instead of Database ...................................................................... Type hint against IDatabase instead of Database Change-Id: I8e2ea8167e7f7f3a41cf321e6387801e1c03c212 --- M src/UpdateTable/Importer/BasicImporter.php 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Daniel Kinzler: Looks good to me, approved jenkins-bot: Verified diff --git a/src/UpdateTable/Importer/BasicImporter.php b/src/UpdateTable/Importer/BasicImporter.php index 1baa8e9..2e19435 100644 --- a/src/UpdateTable/Importer/BasicImporter.php +++ b/src/UpdateTable/Importer/BasicImporter.php @@ -4,7 +4,7 @@ use UnexpectedValueException; use PropertySuggester\UpdateTable\ImportContext; -use Wikimedia\Rdbms\Database; +use Wikimedia\Rdbms\IDatabase; /** * A strategy which imports entries from a CSV file into a DB table. Used as fallback, when no @@ -37,12 +37,12 @@ } /** - * @param $fileHandle - * @param Database $db + * @param resource $fileHandle + * @param IDatabase $db * @param ImportContext $importContext * @throws UnexpectedValueException */ - private function doImport( $fileHandle, Database $db, ImportContext $importContext ) { + private function doImport( $fileHandle, IDatabase $db, ImportContext $importContext ) { $accumulator = []; $batchSize = $importContext->getBatchSize(); $i = 0; -- To view, visit https://gerrit.wikimedia.org/r/401721 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e2ea8167e7f7f3a41cf321e6387801e1c03c212 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/PropertySuggester Gerrit-Branch: master Gerrit-Owner: Thiemo Kreuz (WMDE) <thiemo.kr...@wikimedia.de> Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de> Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits