jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/401741 )
Change subject: Comment out broken test after Chrome upgrade ...................................................................... Comment out broken test after Chrome upgrade Our CI environment uses either Chrome 57 (mediawiki/extensions/VisualEditor) or Chrome 63 (VisualEditor/VisualEditor), but they produce different results, so this test will always fail in at least one of them. Follow-up to 288e6cffd38dde83688ace3b8ba38f2d72c8c4de. Change-Id: Iacd9f7e7d1eb8c05643b4b6a746ebab2bc024d2e --- M tests/ce/ve.ce.Surface.test.js 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Catrope: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/ce/ve.ce.Surface.test.js b/tests/ce/ve.ce.Surface.test.js index 419ecdd..31e5be7 100644 --- a/tests/ce/ve.ce.Surface.test.js +++ b/tests/ce/ve.ce.Surface.test.js @@ -1430,12 +1430,18 @@ '</p>', expectedText: 'Foo\n\n', msg: 'RDFa attributes encoded into data-ve-attributes' - }, + } + /* + // Our CI environment uses either Chrome 57 (mediawiki/extensions/VisualEditor) + // or Chrome 63 (VisualEditor/VisualEditor), but they produce different results, + // so this test will always fail in at least one of them. { rangeOrSelection: new ve.Range( 0, 61 ), - expectedText: 'abc\nd\n\ne\n\nf\n\ng\n\nhi\nj\n\nk\n\nl\n\nm\n\n', + expectedText: 'abc\n\nd\n\ne\n\nf\n\ng\n\nhi\nj\n\nk\n\nl\n\nm\n\n', // Chrome 57 + expectedText: 'abc\nd\n\ne\n\nf\n\ng\n\nhi\nj\n\nk\n\nl\n\nm\n\n', // Chrome 63 msg: 'Plain text of entire document' } + */ ]; function testRunner( doc, rangeOrSelection, expectedData, expectedOriginalRange, expectedBalancedRange, expectedHtml, expectedText, msg ) { -- To view, visit https://gerrit.wikimedia.org/r/401741 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iacd9f7e7d1eb8c05643b4b6a746ebab2bc024d2e Gerrit-PatchSet: 2 Gerrit-Project: VisualEditor/VisualEditor Gerrit-Branch: master Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Catrope <r...@wikimedia.org> Gerrit-Reviewer: Divec <da...@troi.org> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits