Subramanya Sastry has submitted this change and it was merged. Change subject: Move table parsing tests from Parsoid's whitelist into upstream parserTests. ......................................................................
Move table parsing tests from Parsoid's whitelist into upstream parserTests. A few more differences between Parsoid and the PHP parser. Change-Id: Ic12c93fef905b65ffa459bb15920ea7edd9f2238 --- M tests/parser/parserTests.txt 1 file changed, 28 insertions(+), 2 deletions(-) Approvals: Subramanya Sastry: Verified; Looks good to me, approved diff --git a/tests/parser/parserTests.txt b/tests/parser/parserTests.txt index 0d7b4e2..55605d0 100644 --- a/tests/parser/parserTests.txt +++ b/tests/parser/parserTests.txt @@ -3163,16 +3163,30 @@ # is the bare minimun required by the spec, see: # http://www.w3.org/TR/xhtml-modularization/dtd_module_defs.html#a_module_Basic_Tables !! test -A table with no data. +A table with no data. (php) +!! options +php !! input {||} !! result +!! end +# Parsoid team replies: empty table tags are legal in HTML5 +!! test +A table with no data. (parsoid) +!! options +parsoid +!! input +{||} +!! result +<table></table> !! end # A table with nothing but a caption is invalid XHTML, we might want to render # this as <p>caption</p> !! test -A table with nothing but a caption +A table with nothing but a caption (php) +!! options +php !! input {| |+ caption @@ -3183,6 +3197,18 @@ </caption><tr><td></td></tr></table> !! end +# Parsoid team replies: table with only a caption is legal in HTML5 +!! test +A table with nothing but a caption (parsoid) +!! options +parsoid +!! input +{| +|+ caption +|} +!! result +<table><caption> caption</caption></table> +!! end !! test A table with caption with default-spaced attributes and a table row -- To view, visit https://gerrit.wikimedia.org/r/57691 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic12c93fef905b65ffa459bb15920ea7edd9f2238 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Cscott <wikime...@cscott.net> Gerrit-Reviewer: Cscott <wikime...@cscott.net> Gerrit-Reviewer: Subramanya Sastry <ssas...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
