BearND has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402074 )
Change subject: random: fail early when MW API response has no query.pages
......................................................................
random: fail early when MW API response has no query.pages
Stack trace from log files (1001):
500: internal_error","stack":"
TypeError: Cannot read property 'pages' of undefined
at Request.api.mwApiGet.then
(/srv/deployment/mobileapps/deploy-cache/revs/00e60b294482ec067dc48f5b9117bfcc347ac20e/src/lib/feed/random.js:113:50)
at Request.tryCatcher
(/srv/deployment/mobileapps/deploy-cache/revs/00e60b294482ec067dc48f5b9117bfcc347ac20e/node_modules/bluebird/js/release/util.js:16:23)
at Promise._settlePromiseFromHandler
Change-Id: I24c4c32a2c2180aca607c6dfee8745a1699f0e18
---
M lib/feed/random.js
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps
refs/changes/74/402074/1
diff --git a/lib/feed/random.js b/lib/feed/random.js
index 659befa..3c28168 100644
--- a/lib/feed/random.js
+++ b/lib/feed/random.js
@@ -110,6 +110,7 @@
prop: 'extracts|pageterms|pageimages|revisions',
wbptterms: 'description'
}).then((response) => {
+ mwapi.checkForQueryPagesInResponse(req, response);
const scoredResults = response.body.query.pages.map((result) => {
result.score = relativeScoreForResult(result);
return result;
--
To view, visit https://gerrit.wikimedia.org/r/402074
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I24c4c32a2c2180aca607c6dfee8745a1699f0e18
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND <bsitzm...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
