Siebrand has submitted this change and it was merged. Change subject: Add a full stop & Fix comment for grep ......................................................................
Add a full stop & Fix comment for grep Change-Id: I1eb552ca9b6254b0585df8ebcf4d010848f56e2b --- M ReaderFeedback.hooks.php M language/RatedPages.i18n.php 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Siebrand: Verified; Looks good to me, approved diff --git a/ReaderFeedback.hooks.php b/ReaderFeedback.hooks.php index 37085ed..c183f86 100644 --- a/ReaderFeedback.hooks.php +++ b/ReaderFeedback.hooks.php @@ -135,8 +135,8 @@ $levels = array_reverse($levels,true); foreach( $levels as $i => $name ) { // Give grep a chance to find the usages: - // readerfeedback-level-none, readerfeedback-level-0, readerfeedback-level-1, - // readerfeedback-level-2, readerfeedback-level-3, readerfeedback-level-4 + // readerfeedback-level-0, readerfeedback-level-1, readerfeedback-level-2, + // readerfeedback-level-3, readerfeedback-level-4 $optionClass = array( 'class' => "rfb-rating-option-$i" ); $form .= Xml::option( wfMessage("readerfeedback-level-$i")->text(), $i, ($i == $selected), $optionClass ) ."\n"; } diff --git a/language/RatedPages.i18n.php b/language/RatedPages.i18n.php index 1dd165c..4b187d5 100644 --- a/language/RatedPages.i18n.php +++ b/language/RatedPages.i18n.php @@ -11,7 +11,7 @@ 'ratedpages' => 'Reader rated pages', 'ratedpages-leg' => 'Find pages rated with a sizeable number of ratings', 'ratedpages-list' => 'Below is a list of pages sorted by their reader feedback rating.', - 'ratedpages-none' => 'There are no pages in this list', + 'ratedpages-none' => 'There are no pages in this list.', 'ratedpages-graphs' => 'rating data', 'ratedpages-count' => '$1 {{PLURAL:$1|review|reviews}}', ); -- To view, visit https://gerrit.wikimedia.org/r/57822 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1eb552ca9b6254b0585df8ebcf4d010848f56e2b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ReaderFeedback Gerrit-Branch: master Gerrit-Owner: Shirayuki <shirayuk...@gmail.com> Gerrit-Reviewer: Siebrand <siebr...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits