VolkerE has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402756 )
Change subject: WikimediaUI theme: Align size and position of overhauled icons
......................................................................
WikimediaUI theme: Align size and position of overhauled icons
Bug: T177432
Change-Id: I154f638abd1f552018a3ef9d046627b88cfe9a13
---
M src/themes/wikimediaui/common.less
M src/themes/wikimediaui/elements.less
M src/themes/wikimediaui/widgets.less
3 files changed, 8 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/56/402756/1
diff --git a/src/themes/wikimediaui/common.less
b/src/themes/wikimediaui/common.less
index a904fec..c69de80 100644
--- a/src/themes/wikimediaui/common.less
+++ b/src/themes/wikimediaui/common.less
@@ -64,14 +64,14 @@
@size-fieldlayout-help-icon: 22 / @oo-ui-font-size-browser /
@oo-ui-font-size-base;
@size-tool: 40 / @oo-ui-font-size-browser / @oo-ui-font-size-base; // equals
`3.125em`≈`40px`
-@start-framed-icon-only: 7 / @oo-ui-font-size-browser / @oo-ui-font-size-base;
// equals `0.547em`≈`7px`; HACK: We have to break with
`@padding-start-input-text-icon` to perfectly center in `@min-width-button-base`
+@start-framed-icon-only: 10 / @oo-ui-font-size-browser /
@oo-ui-font-size-base; // equals `0.547em`≈`7px`; HACK: We have to break with
`@padding-start-input-text-icon` to perfectly center in `@min-width-button-base`
@start-framed-icon-only-numberinput: 6 / @oo-ui-font-size-browser /
@oo-ui-font-size-base; // equals `0.46875em`≈`6px`
@start-framed-indicator-only: 13 / @oo-ui-font-size-browser /
@oo-ui-font-size-base; // equals `1.09375em`≈`14px`; `@size-indicator + 2 *
@border-width-base`
@start-framed-square-indicator-only: 9 / @oo-ui-font-size-browser /
@oo-ui-font-size-base; // equals `0.703125em`≈`9px`
@start-frameless: -@start-frameless-icon;
@start-frameless-icon: 3 / @oo-ui-font-size-browser / @oo-ui-font-size-base;
@start-tagmultiselect-input: 5 / @oo-ui-font-size-browser /
@oo-ui-font-size-base; // equals `0.390625em`≈`5px`;
`@padding-horizontal-tagitem` + `@border-width-base`
-@start-tool-icon-indicator: 8 / @oo-ui-font-size-browser /
@oo-ui-font-size-base;
+@start-tool-icon-indicator: 12 / @oo-ui-font-size-browser /
@oo-ui-font-size-base;
@start-toolbar-narrow-tool-icon: 4 / @oo-ui-font-size-browser /
@oo-ui-font-size-base;
@end-tagitem: 4 / @oo-ui-font-size-browser / @oo-ui-font-size-base; // equals
`0.3125em`≈`4px`
@@ -133,7 +133,6 @@
@padding-bottom-base: 7 / @oo-ui-font-size-browser / @oo-ui-font-size-base; //
equals `0.547em`≈`7px`
@padding-bottom-menu: 8 / @oo-ui-font-size-browser / @oo-ui-font-size-base;
@padding-bottom-tool-label: 12 / @oo-ui-font-size-browser /
@oo-ui-font-size-base;
-@padding-start-input-text-icon: 6 / @oo-ui-font-size-browser /
@oo-ui-font-size-base; // As long as we have whitespace in icon canvas, we need
reduced `padding-left`.
@padding-start-icon: @size-icon;
@padding-start-icon-only: 26 / @oo-ui-font-size-browser /
@oo-ui-font-size-base; // equals `2.03125em`≈`26px`; @min-width-button-base -
@padding-horizontal-base - 2 * @border-width-base;
@padding-start-fieldset-header-iconized: 26 / @oo-ui-font-size-browser / (
@oo-ui-font-size-base * @font-size-fieldset-header );
diff --git a/src/themes/wikimediaui/elements.less
b/src/themes/wikimediaui/elements.less
index 585adef..946b7dc 100644
--- a/src/themes/wikimediaui/elements.less
+++ b/src/themes/wikimediaui/elements.less
@@ -271,7 +271,7 @@
padding-left:
@padding-start-input-text-icon-label;
> .oo-ui-iconElement-icon {
- left:
@padding-start-input-text-icon;
+ //left:
@padding-horizontal-input-text;
}
}
}
diff --git a/src/themes/wikimediaui/widgets.less
b/src/themes/wikimediaui/widgets.less
index 7348fbb..810cd2b 100644
--- a/src/themes/wikimediaui/widgets.less
+++ b/src/themes/wikimediaui/widgets.less
@@ -265,7 +265,7 @@
padding-left: @padding-start-input-text-icon-label;
> .oo-ui-iconElement-icon {
- left: @padding-start-input-text-icon;
+ left: @padding-horizontal-input-text;
}
}
@@ -570,7 +570,7 @@
line-height: @line-height-reset;
.oo-ui-iconElement-icon {
- left: @padding-start-input-text-icon;
+ left: @padding-horizontal-input-text;
}
.oo-ui-indicatorElement-indicator {
@@ -1364,7 +1364,7 @@
> .oo-ui-iconElement-icon {
display: none;
top: -@border-width-base; // Address `border-top` of
parent element
- left: @padding-start-input-text-icon;
+ left: @padding-horizontal-input-text;
min-height: @min-height-widget-base;
margin-left: -@border-width-base; // Address extra
`border-left` pixel above
}
@@ -1397,7 +1397,7 @@
&-clearButton {
top: -1px; // Address `border-width`
- right: @padding-start-input-text-icon; // With close, no
indicator
+ right: @padding-horizontal-input-text; // With close, no
indicator
min-width: @min-size-icon;
width: @size-icon;
margin-right: 0;
@@ -1907,7 +1907,7 @@
}
> .oo-ui-iconElement-icon {
- left: @padding-start-input-text-icon;
+ left: @padding-horizontal-input-text;
}
textarea + .oo-ui-iconElement-icon {
--
To view, visit https://gerrit.wikimedia.org/r/402756
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I154f638abd1f552018a3ef9d046627b88cfe9a13
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
